Add support for Conceal #1514
Add support for Conceal #1514
Conversation
Fix typo with `Cryptonight` being mispelled `Crytonight`
|
Thanks for the PR. Checking. |
Thank you :) Yes, i tested it out on I have it running on |
Add support for Ubiq Fix couple of issues with EthereumPayoutHandler.cs Add pool examples for Conceal, Ethereum Classic and Ubiq Fix few issues with Conceal when user forget to specify the `NetworkType` in the config.json Rename `NetworkTypeSpecified` to `NetworkTypeOverride` in order to be more comprehensible
|
@blackmennewstyle do you think it would be possible to use the libsodium from libethhash? Otherwise there is a lot unnecessary duplicated code. And maybe create a separate PR for the etc and ubiq stuff to make a review a bit easier? |
|
@jon4hz Yeah i can definitely try to do that as soon as i get some free times :) |
|
Stupid question but how do i create another pull request, it does not seem to allow to create one more as long as this one is pending :/ |
src/Native/libetchash/io_posix.c
Outdated
|
|
||
| bool ethash_get_default_dirname(char* strbuf, size_t buffsize) | ||
| { | ||
| static const char dir_suffix[] = ".ethash/"; |
There was a problem hiding this comment.
Should we make the suffix ".etchash/" ? Would fit better imo.
There was a problem hiding this comment.
Yes, sounds like a good idea. I can do the same for ubqhash, it will match with the default name respectively for:
geth, when using--classicor--mordor:.etchash/gubiq:.ubqhash/
| @@ -352,9 +356,24 @@ public override void Configure(PoolConfig pc, ClusterConfig cc) | |||
|
|
|||
| // create it if necessary | |||
| Directory.CreateDirectory(dagDir); | |||
|
|
|||
There was a problem hiding this comment.
var dagDir = !string.IsNullOrEmpty(extraPoolConfig?.DagDir) ?
Environment.ExpandEnvironmentVariables(extraPoolConfig.DagDir) :
Dag.GetDefaultDagDirectory();should probably be handled on a per "algo" basis, since each algo has it's own Dag.GetDefaultDagDirectory() function.
There was a problem hiding this comment.
Yes absolutely. I can't believe i actually missed it. i will do it right away and test it.
You'd have to create another branch in your source repo and use that new branch for the PR. |
|
One other thing: Currently the API will return always "ethhash" as algo because of A while ago I started working on ETC support myself and I built an interface around ethash algo(s) which would solve that issue and also simplify other parts of the code. I never finished that code but parts of it were working. I'll see if I can find it and open a PR. |
|
Sorry for the late response. Been battling with Covid and then another flu since pretty much christmas. Pretty impressive job. Implementing a new family is no easy feat 👍 |
That would be awesome. 👍 |
Add support for Conceal
Fix typo with
Cryptonightbeing mispelledCrytonight