Skip to content
This repository has been archived by the owner on Oct 20, 2023. It is now read-only.

StratumShare record #1536

Closed
jon4hz opened this issue Dec 5, 2022 · 1 comment
Closed

StratumShare record #1536

jon4hz opened this issue Dec 5, 2022 · 1 comment

Comments

@jon4hz
Copy link
Contributor

jon4hz commented Dec 5, 2022 •
edited
Loading

Hey,

Is the Connection parameter required here?

miningcore/src/Miningcore/Mining/StratumShare.cs

Line 6 in 171a262

public record StratumShare(StratumConnection Connection, Share Share);

From what I can see, this field is accessed nowhere else.
@oliverw
Copy link
Owner

oliverw commented Dec 5, 2022

There used to be listeners on the message bus that cared for the Connection member but those are long gone since the vardiff rework. I'll remove it. Thanks for the advice.

oliverw pushed a commit that referenced this issue Dec 5, 2022
Remove obsolete StratumShare object. Fixes #1536
d3dcec6
@oliverw oliverw closed this as completed Dec 5, 2022
blackmennewstyle pushed a commit to blackmennewstyle/miningcore that referenced this issue Dec 12, 2022
Remove obsolete StratumShare object. Fixes oliverw#1536
683d8dc
Censseo pushed a commit to JJPool/origin-fork-miningcore that referenced this issue Jan 29, 2023
@Censseo
Remove obsolete StratumShare object. Fixes oliverw#1536
a9b146e
Censseo pushed a commit to JJPool/origin-fork-miningcore that referenced this issue Feb 1, 2023
@Censseo
Remove obsolete StratumShare object. Fixes oliverw#1536
f4af411
Censseo pushed a commit to JJPool/origin-fork-miningcore that referenced this issue Feb 1, 2023
@Censseo
Remove obsolete StratumShare object. Fixes oliverw#1536
e7c0c35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@oliverw @jon4hz