Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add resource-set and role attributes to Role model #988

Merged
merged 1 commit into from
Mar 6, 2024
Merged

Add resource-set and role attributes to Role model #988

merged 1 commit into from
Mar 6, 2024

Conversation

clementdenis
Copy link
Contributor

Issue(s)

The Role model is missing the custom role assignment properties resource-set and role.

Description

Custom role assignments have two additional properties resource-set and role compared to standard role assignments:
https://developer.okta.com/docs/reference/api/roles/#sample-custom-role-assigned-to-the-user-directly

=> these two properties are missing from the OpenAPI spec in SDK v15.

Category

  • Bugfix
  • Enhancement
  • New Feature
  • Library Upgrade
  • Configuration Change
  • Versioning Change
  • Unit or Integration Test(s)
  • Documentation

Signoff

  • I have submitted a CLA for this PR
  • Each commit message explains what the commit does
  • I have updated documentation to explain what my PR does
  • My code is covered by tests if required
  • I did not edit any automatically generated files

@clementdenis clementdenis mentioned this pull request Mar 6, 2024
Closed
13 tasks
@arvindkrishnakumar-okta arvindkrishnakumar-okta changed the base branch from master to ak_add_resource_set_and_roles_spec March 6, 2024 18:03
@arvindkrishnakumar-okta arvindkrishnakumar-okta merged commit 6ee1aec into okta:ak_add_resource_set_and_roles_spec Mar 6, 2024
@arvindkrishnakumar-okta arvindkrishnakumar-okta mentioned this pull request Mar 6, 2024
Merged
13 tasks
arvindkrishnakumar-okta added a commit that referenced this pull request Mar 6, 2024
@arvindkrishnakumar-okta @clementdenis @canataly-backupta
Add resource-set and role attributes to Role model (#988) (#989)
be778a3 
Co-authored-by: Clément Denis <[email protected]>
Co-authored-by: Can Atalay <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@clementdenis @arvindkrishnakumar-okta @canataly-backupta