Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add resource-set and role attributes to Role model #2

Closed
wants to merge 1 commit into from

Conversation

canataly-backupta
Copy link
Collaborator

@canataly-backupta canataly-backupta commented Mar 5, 2024

Issue(s)

Okta Java SDK is not deserializing resource-set and role attributes of custom roles in Role model.

Description

Since Fix deserialization of polymorphic types when discriminator property is unknown or null still in progress, attributes are added to Role model itself; however, then can be added to sub-class later on.

Category

  • Bugfix
  • Enhancement
  • New Feature
  • Library Upgrade
  • Configuration Change
  • Versioning Change
  • Unit or Integration Test(s)
  • Documentation

Signoff

  • I have submitted a CLA for this PR
  • Each commit message explains what the commit does
  • I have updated documentation to explain what my PR does
  • My code is covered by tests if required
  • I did not edit any automatically generated files

This change is Reviewable

@clementdenis
Copy link
Owner

Opened a PR to upstream project: okta#988

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants