Merge pull request #46 from okta/MO_xcov

Rename scheme to DeviceAuthenticatorFramework and add xcov step
okta · Aug 9, 2022 · 0ac0d4a · 0ac0d4a
2 parents 6a07895 + 4aa0136
commit 0ac0d4a
Show file tree

Hide file tree

Showing 3 changed files with 31 additions and 8 deletions.
diff --git a/.github/workflows/okta_devices.yml b/.github/workflows/okta_devices.yml
@@ -31,3 +31,15 @@ jobs:
       run: pod install
     - name: Functional Tests
       run: set -o pipefail && xcodebuild -workspace DeviceAuthenticator.xcworkspace -scheme "DeviceAuthenticatorFunctionalTests" -destination "platform=iOS Simulator,OS=latest,name=iPhone 12" test | xcpretty
+  CodeCoverage:
+    runs-on: macos-12
+    steps:
+    - name: Checkout project
+      uses: actions/checkout@v2
+    - name: Install xcov
+      run: gem install xcov
+    - name: Run code coverage for all tests
+      run: |
+        pod install
+        xcodebuild -workspace DeviceAuthenticator.xcworkspace -scheme "DeviceAuthenticatorFramework" -derivedDataPath CodeCov -destination "platform=iOS Simulator,OS=latest,name=iPhone 12" -enableCodeCoverage YES clean build test -quiet
+        xcov -s DeviceAuthenticatorFramework -j CodeCov
diff --git a/DeviceAuthenticator.xcodeproj/project.pbxproj b/DeviceAuthenticator.xcodeproj/project.pbxproj
@@ -370,7 +370,7 @@
 		7F88340C287C763C0034CA5E /* Info.plist */ = {isa = PBXFileReference; lastKnownFileType = text.plist.xml; path = Info.plist; sourceTree = "<group>"; };
 		7F883414287CA8B80034CA5E /* PushSDKTestApp.entitlements */ = {isa = PBXFileReference; lastKnownFileType = text.plist.entitlements; path = PushSDKTestApp.entitlements; sourceTree = "<group>"; };
 		7F8FF73C287F87DA000F17F2 /* DeviceAuthenticator.docc */ = {isa = PBXFileReference; lastKnownFileType = folder.documentationcatalog; path = DeviceAuthenticator.docc; sourceTree = "<group>"; };
-		7FFB5F74285BA94A006BC548 /* DeviceAuthenticator.framework */ = {isa = PBXFileReference; explicitFileType = wrapper.framework; includeInIndex = 0; path = DeviceAuthenticator.framework; sourceTree = BUILT_PRODUCTS_DIR; };
+		7FFB5F74285BA94A006BC548 /* DeviceAuthenticatorFramework.framework */ = {isa = PBXFileReference; explicitFileType = wrapper.framework; includeInIndex = 0; path = DeviceAuthenticatorFramework.framework; sourceTree = BUILT_PRODUCTS_DIR; };
 		7FFB5FFA286A7F4C006BC548 /* DeviceAuthenticatorUnitTests.xctest */ = {isa = PBXFileReference; explicitFileType = wrapper.cfbundle; includeInIndex = 0; path = DeviceAuthenticatorUnitTests.xctest; sourceTree = BUILT_PRODUCTS_DIR; };
 		7FFB6010286A80CF006BC548 /* DeviceAuthenticatorFunctionalTests.xctest */ = {isa = PBXFileReference; explicitFileType = wrapper.cfbundle; includeInIndex = 0; path = DeviceAuthenticatorFunctionalTests.xctest; sourceTree = BUILT_PRODUCTS_DIR; };
 		9F47E555289C989000299CFB /* DeviceAuthenticatorConfigTests.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = DeviceAuthenticatorConfigTests.swift; sourceTree = "<group>"; };
@@ -746,7 +746,7 @@
 		7FFB5F75285BA94A006BC548 /* Products */ = {
 			isa = PBXGroup;
 			children = (
-				7FFB5F74285BA94A006BC548 /* DeviceAuthenticator.framework */,
+				7FFB5F74285BA94A006BC548 /* DeviceAuthenticatorFramework.framework */,
 				7FFB5FFA286A7F4C006BC548 /* DeviceAuthenticatorUnitTests.xctest */,
 				7FFB6010286A80CF006BC548 /* DeviceAuthenticatorFunctionalTests.xctest */,
 				7F8833FC287C763A0034CA5E /* PushSDKTestApp.app */,
@@ -974,7 +974,7 @@
 			);
 			name = DeviceAuthenticator;
 			productName = DeviceAuthenticator;
-			productReference = 7FFB5F74285BA94A006BC548 /* DeviceAuthenticator.framework */;
+			productReference = 7FFB5F74285BA94A006BC548 /* DeviceAuthenticatorFramework.framework */;
 			productType = "com.apple.product-type.framework";
 		};
 		7FFB5FF9286A7F4C006BC548 /* DeviceAuthenticatorUnitTests */ = {
@@ -1655,7 +1655,7 @@
 				);
 				MARKETING_VERSION = 1.0;
 				PRODUCT_BUNDLE_IDENTIFIER = com.okta.DeviceAuthenticator;
-				PRODUCT_NAME = DeviceAuthenticator;
+				PRODUCT_NAME = DeviceAuthenticatorFramework;
 				SKIP_INSTALL = YES;
 				SUPPORTS_MACCATALYST = NO;
 				SWIFT_EMIT_LOC_STRINGS = YES;
@@ -1688,7 +1688,7 @@
 				);
 				MARKETING_VERSION = 1.0;
 				PRODUCT_BUNDLE_IDENTIFIER = com.okta.DeviceAuthenticator;
-				PRODUCT_NAME = DeviceAuthenticator;
+				PRODUCT_NAME = DeviceAuthenticatorFramework;
 				SKIP_INSTALL = YES;
 				SUPPORTS_MACCATALYST = NO;
 				SWIFT_EMIT_LOC_STRINGS = YES;

diff --git a/...ta/xcschemes/DeviceAuthenticator.xcscheme → ...mes/DeviceAuthenticatorFramework.xcscheme b/...ta/xcschemes/DeviceAuthenticator.xcscheme → ...mes/DeviceAuthenticatorFramework.xcscheme
@@ -15,7 +15,7 @@
             <BuildableReference
                BuildableIdentifier = "primary"
                BlueprintIdentifier = "7FFB5F73285BA94A006BC548"
-               BuildableName = "DeviceAuthenticator.framework"
+               BuildableName = "DeviceAuthenticatorFramework.framework"
                BlueprintName = "DeviceAuthenticator"
                ReferencedContainer = "container:DeviceAuthenticator.xcodeproj">
             </BuildableReference>
@@ -40,7 +40,18 @@
       buildConfiguration = "Debug"
       selectedDebuggerIdentifier = "Xcode.DebuggerFoundation.Debugger.LLDB"
       selectedLauncherIdentifier = "Xcode.DebuggerFoundation.Launcher.LLDB"
-      shouldUseLaunchSchemeArgsEnv = "YES">
+      shouldUseLaunchSchemeArgsEnv = "YES"
+      codeCoverageEnabled = "YES"
+      onlyGenerateCoverageForSpecifiedTargets = "YES">
+      <CodeCoverageTargets>
+         <BuildableReference
+            BuildableIdentifier = "primary"
+            BlueprintIdentifier = "7FFB5F73285BA94A006BC548"
+            BuildableName = "DeviceAuthenticatorFramework.framework"
+            BlueprintName = "DeviceAuthenticator"
+            ReferencedContainer = "container:DeviceAuthenticator.xcodeproj">
+         </BuildableReference>
+      </CodeCoverageTargets>
       <Testables>
          <TestableReference
             skipped = "NO">
@@ -85,7 +96,7 @@
          <BuildableReference
             BuildableIdentifier = "primary"
             BlueprintIdentifier = "7FFB5F73285BA94A006BC548"
-            BuildableName = "DeviceAuthenticator.framework"
+            BuildableName = "DeviceAuthenticatorFramework.framework"
             BlueprintName = "DeviceAuthenticator"
             ReferencedContainer = "container:DeviceAuthenticator.xcodeproj">
          </BuildableReference>