OKTA-522764 - Push SDK: Fix spelling mistake in parameter name (#45)

okta · Aug 9, 2022 · 6a07895 · 6a07895
1 parent 6bf4d03
commit 6a07895
Show file tree

Hide file tree

Showing 6 changed files with 13 additions and 10 deletions.
diff --git a/Sources/DeviceAuthenticator/DomainObjects/AuthenticatorMetaDataModel.swift b/Sources/DeviceAuthenticator/DomainObjects/AuthenticatorMetaDataModel.swift
@@ -26,7 +26,7 @@ struct AuthenticatorMetaDataModel: Codable {
     struct Settings: Codable {
         let appInstanceId: String?
         let userVerification: UserVerificationSetting?
-        let oauthCliendId: String?
+        let oauthClientId: String?
 
         public enum UserVerificationSetting {
             case preferred

diff --git a/Sources/DeviceAuthenticator/Enrollment/AuthenticatorEnrollment.swift b/Sources/DeviceAuthenticator/Enrollment/AuthenticatorEnrollment.swift
@@ -114,7 +114,7 @@ class AuthenticatorEnrollment: AuthenticatorEnrollmentProtocol {
                                                   activationToken: nil,
                                                   orgHost: organization.url,
                                                   authenticatorKey: policy.metadata.key,
-                                                  oidcClientId: policy.metadata.settings?.oauthCliendId,
+                                                  oidcClientId: policy.metadata.settings?.oauthClientId,
                                                   pushToken: DeviceToken.tokenData(token),
                                                   enrollBiometricKey: nil,
                                                   deviceSignals: nil,
@@ -189,7 +189,7 @@ class AuthenticatorEnrollment: AuthenticatorEnrollmentProtocol {
                                                   activationToken: nil,
                                                   orgHost: orgHost,
                                                   authenticatorKey: policy.metadata.id,
-                                                  oidcClientId: policy.metadata.settings?.oauthCliendId,
+                                                  oidcClientId: policy.metadata.settings?.oauthClientId,
                                                   pushToken: deviceToken,
                                                   enrollBiometricKey: enable,
                                                   deviceSignals: nil,

diff --git a/Tests/DeviceAuthenticatorUnitTests/AuthenticatorObjectTests.swift b/Tests/DeviceAuthenticatorUnitTests/AuthenticatorObjectTests.swift
@@ -25,6 +25,7 @@ class AuthenticatorObjectTests: XCTestCase {
         XCTAssertEqual(metaData.key, "okta_verify")
         XCTAssertEqual(metaData.type, "APP")
         XCTAssertEqual(metaData._embedded.methods.count, 3)
+        XCTAssertEqual(metaData.settings?.oauthClientId, "someOAuth2ClientId")
         metaData._embedded.methods.forEach({ authenticatorType in
             if authenticatorType.type == .totp {
                 XCTAssertEqual(authenticatorType.status, "INACTIVE")

diff --git a/Tests/DeviceAuthenticatorUnitTests/AuthenticatorPolicyTests.swift b/Tests/DeviceAuthenticatorUnitTests/AuthenticatorPolicyTests.swift
@@ -31,22 +31,22 @@ class AuthenticatorPolicyTests: XCTestCase {
         XCTAssertEqual(policy.userVerificationSetting, .preferred)
 
         policy = AuthenticatorPolicy(metadata: createMetadataWithSettings(
-                                        AuthenticatorMetaDataModel.Settings(appInstanceId: nil, userVerification: nil, oauthCliendId: nil)
+                                        AuthenticatorMetaDataModel.Settings(appInstanceId: nil, userVerification: nil, oauthClientId: nil)
         ))
         XCTAssertEqual(policy.userVerificationSetting, .preferred)
 
         policy = AuthenticatorPolicy(metadata: createMetadataWithSettings(
-            AuthenticatorMetaDataModel.Settings(appInstanceId: nil, userVerification: .preferred, oauthCliendId: nil)
+            AuthenticatorMetaDataModel.Settings(appInstanceId: nil, userVerification: .preferred, oauthClientId: nil)
         ))
         XCTAssertEqual(policy.userVerificationSetting, .preferred)
 
         policy = AuthenticatorPolicy(metadata: createMetadataWithSettings(
-            AuthenticatorMetaDataModel.Settings(appInstanceId: nil, userVerification: .required, oauthCliendId: nil)
+            AuthenticatorMetaDataModel.Settings(appInstanceId: nil, userVerification: .required, oauthClientId: nil)
         ))
         XCTAssertEqual(policy.userVerificationSetting, .required)
 
         policy = AuthenticatorPolicy(metadata: createMetadataWithSettings(
-            AuthenticatorMetaDataModel.Settings(appInstanceId: nil, userVerification: .unknown(""), oauthCliendId: nil)
+            AuthenticatorMetaDataModel.Settings(appInstanceId: nil, userVerification: .unknown(""), oauthClientId: nil)
         ))
         XCTAssertEqual(policy.userVerificationSetting, .unknown(""))
     }

diff --git a/Tests/DeviceAuthenticatorUnitTests/Mocks/GoldenData.swift b/Tests/DeviceAuthenticatorUnitTests/Mocks/GoldenData.swift
@@ -28,7 +28,8 @@ class GoldenData {
             "lastUpdated": "2017-01-24T19:52:34.000Z",
             "settings": {
                 "appInstanceId": "oidcAppId1234",
-                "userVerification": "preferred"
+                "userVerification": "preferred",
+                "oauthClientId": "someOAuth2ClientId"
             },
             "_links": {
                 "enroll": {
@@ -82,7 +83,8 @@ class GoldenData {
             "lastUpdated": "2017-01-24T19:52:34.000Z",
             "settings": {
                 "appInstanceId": "oidcAppId1234",
-                "userVerification": "preferred"
+                "userVerification": "preferred",
+                "oauthClientId": "someOAuth2ClientId"
             },
             "_links": {
                 "self": {

diff --git a/Tests/DeviceAuthenticatorUnitTests/Mocks/TestUtils.swift b/Tests/DeviceAuthenticatorUnitTests/Mocks/TestUtils.swift
@@ -129,7 +129,7 @@ class TestUtils {
                                                 methods: [AuthenticatorMethod] = [.push, .signedNonce]) -> AuthenticatorMetaDataModel {
         let settings = AuthenticatorMetaDataModel.Settings(appInstanceId: nil,
                                                            userVerification: userVerification,
-                                                           oauthCliendId: nil)
+                                                           oauthClientId: nil)
 
         var embeddedMethods = [AuthenticatorMetaDataModel.Method]()
         for method in methods {