Standardize URL queries: use same URL components for querying by 'not accomplished step' and writing back 'accomplished step' #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
callunity
commented
Oct 20, 2023
callunity
commented
- Includes a change file
- Updates developer documentation
… accomplished step' and writing back 'accomplished step'
avarsava
reviewed
Oct 23, 2023
| @@ -427,7 +427,7 @@ | |||
| } | |||
| } | |||
| }, | |||
| "/case/{caseIdentifier}/files-loaded-into-vidarr-archival": { | |||
| "/case/{caseIdentifier}/sent-to-vidarr-archival": { | |||
There was a problem hiding this comment.
The URL now says 'sent to' vidarr archival, but the description says they were loaded. Is it possible to send to vidarr archival then have the loading process fail? What would be returned in that case?
There was a problem hiding this comment.
There's no Nabu code that talks to Vidarr, so it's the responsibility of the client/calling script to check that the /load request was successful before writing back to this Nabu endpoint. Here's the current script that writes back to this endpoint after copying files and then loading metadata to vidarr-archival.
avarsava
approved these changes
Oct 23, 2023
grapigeau
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.