Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix case where HC vehicles are remote-spawned with no roads near HQ #3235

Merged

Conversation

jaj22
Copy link

@jaj22 jaj22 commented Apr 21, 2024

What type of PR is this.

  1. Bug
  2. Change
  3. Enhancement

What have you changed and why?

If high command squads containing vehicles are purchased when the commander is away from HQ, and the HQ has no roads within 100m, the placement code breaks. This PR fixes it to place the vehicle randomly as intended.

Please specify which Issue this PR Resolves.

closes #XXXX

Please verify the following and ensure all checks are completed.

  1. Have you loaded the mission in LAN host?
  2. Have you loaded the mission on a dedicated server?

Is further testing or are further changes required?

  1. No
  2. Yes (Please provide further detail below.)

@jaj22 jaj22 added Bug Something isn't working Review pending labels Apr 21, 2024
@jaj22 jaj22 added this to the 3.6 milestone Apr 21, 2024
@Bob-Murphy Bob-Murphy modified the milestones: 3.6, 3.5.4 Apr 21, 2024
Copy link

@ante185 ante185 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appears to work as expected.
Vehicles may or may not have an elevated chance of getting damaged or destroyed when spawned in, but it's an substantial improvement over spawning at 0,0,0 and guaranteed to be lost.

@Bob-Murphy Bob-Murphy merged commit 7528fcb into official-antistasi-community:unstable Apr 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants