Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fn_vehiclePrice to not fail on absent vehicles. #3228

Conversation

ante185
Copy link

@ante185 ante185 commented Apr 17, 2024

What type of PR is this.

  1. Bug
  2. Change
  3. Enhancement

What have you changed and why?

Information:
Adds a check to fn_vehiclePrice that ensure the function doesn't error when _typeX is nil.
This would be the first step in the direction of letting some rebel templates have less stuff.

Reformatted file.
Cleaned up the non-seaport based discount

Please specify which Issue this PR Resolves.

closes #XXXX

Please verify the following and ensure all checks are completed.

  1. Have you loaded the mission in LAN host?
  2. Have you loaded the mission on a dedicated server?

Is further testing or are further changes required?

  1. No
  2. Yes (Please provide further detail below.)

How can the changes be tested?

Steps:


Notes:

@ante185 ante185 added Change A change to existing functionality Review pending labels Apr 17, 2024
@ante185 ante185 requested review from jaj22 and Tiny-DM April 18, 2024 17:37
@jaj22 jaj22 added this to the 3.6 milestone Apr 18, 2024
@ante185 ante185 mentioned this pull request Apr 18, 2024
7 tasks
@Bob-Murphy Bob-Murphy merged commit 0811130 into official-antistasi-community:unstable Apr 28, 2024
@Bob-Murphy Bob-Murphy added the Added to changelog Added to changelog label Jun 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Added to changelog Added to changelog Change A change to existing functionality Ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants