forked from Bob-Murphy/A3-Antistasi-1.4
-
-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Assassinate mission misc fixes #3064
Merged
Bob-Murphy
merged 4 commits into
official-antistasi-community:unstable
from
Tiny-DM:AS-mission-fix
Nov 25, 2023
Merged
Assassinate mission misc fixes #3064
Bob-Murphy
merged 4 commits into
official-antistasi-community:unstable
from
Tiny-DM:AS-mission-fix
Nov 25, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaj22
reviewed
Nov 23, 2023
jaj22
reviewed
Nov 23, 2023
all issues should be fixed. ready for review |
You managed to test the specops mission eventually, right? |
@jaj22 Yes. I got the file running properly with the includes, I really should have asked for clarification earlier. Sorry about that. |
jaj22
approved these changes
Nov 24, 2023
Bob-Murphy
requested changes
Nov 24, 2023
Bob-Murphy
added
Change requested
A change has been requested, and this can't be merged until it's done.
and removed
Ready for merge
labels
Nov 24, 2023
Change resolved. In the future it might be cool to grab the name for the vehicle it spawns and trim it down, but that's a minor fix for the future. |
Bob-Murphy
approved these changes
Nov 25, 2023
Bob-Murphy
added
Ready for merge
and removed
Change requested
A change has been requested, and this can't be merged until it's done.
labels
Nov 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this.
What have you changed and why?
Stringtable: Changed SpecOps to Special Forces. Personal preference, I've heard this and "SF" a lot more than SpecOps, and it's a bit less confusing
Officer mission should render time and faction correctly, and removed a few useless lines
Traitor mission, removed a few useless lines and the old pvp mission
SpecOps: The faction should be displayed correctly, SEE BELOW
Please specify which Issue this PR Resolves.
closes https://discord.com/channels/449481990513754112/647694189236322305/1139340437132419212
Please verify the following and ensure all checks are completed.
Is further testing or are further changes required?
How can the changes be tested?
Steps:
Officer: Move to the middle of the peninsula south of the southwest airbase, and call an assassinate mission, or move HQ to the middle of the ocean.
Notes: