Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assassinate mission misc fixes #3064

Merged

Conversation

Tiny-DM
Copy link

@Tiny-DM Tiny-DM commented Nov 23, 2023

What type of PR is this.

  1. Bug
  2. Change
  3. Enhancement

What have you changed and why?

Stringtable: Changed SpecOps to Special Forces. Personal preference, I've heard this and "SF" a lot more than SpecOps, and it's a bit less confusing
Officer mission should render time and faction correctly, and removed a few useless lines
Traitor mission, removed a few useless lines and the old pvp mission
SpecOps: The faction should be displayed correctly, SEE BELOW

Please specify which Issue this PR Resolves.

closes https://discord.com/channels/449481990513754112/647694189236322305/1139340437132419212

Please verify the following and ensure all checks are completed.

  1. Have you loaded the mission in LAN host?
  2. Have you loaded the mission on a dedicated server?

Is further testing or are further changes required?

  1. No
  2. Yes (Please provide further detail below.)

How can the changes be tested?

Steps:
Officer: Move to the middle of the peninsula south of the southwest airbase, and call an assassinate mission, or move HQ to the middle of the ocean.


Notes:

@Tiny-DM
Copy link
Author

Tiny-DM commented Nov 23, 2023

all issues should be fixed. ready for review

@jaj22
Copy link

jaj22 commented Nov 24, 2023

You managed to test the specops mission eventually, right?

@jaj22 jaj22 added the Bug Something isn't working label Nov 24, 2023
@jaj22 jaj22 added this to the 3.4.1 milestone Nov 24, 2023
@Tiny-DM
Copy link
Author

Tiny-DM commented Nov 24, 2023

@jaj22 Yes. I got the file running properly with the includes, I really should have asked for clarification earlier. Sorry about that.

A3A/addons/core/Stringtable.xml Outdated Show resolved Hide resolved
@Bob-Murphy Bob-Murphy added Change requested A change has been requested, and this can't be merged until it's done. and removed Ready for merge labels Nov 24, 2023
@Tiny-DM
Copy link
Author

Tiny-DM commented Nov 24, 2023

Change resolved. In the future it might be cool to grab the name for the vehicle it spawns and trim it down, but that's a minor fix for the future.

@Bob-Murphy Bob-Murphy added Ready for merge and removed Change requested A change has been requested, and this can't be merged until it's done. labels Nov 25, 2023
@Bob-Murphy Bob-Murphy merged commit 8d82765 into official-antistasi-community:unstable Nov 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants