params update #3058
Merged
params update #3058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If we're changing default membership to off then the natural change is to disable FF punishment by default too. |
|
Does disabling FF only stops the punishment or also the logging and the pop-ups? |
|
@Bob-Murphy Yes. fn_punishment_checkstatus and fn_punishment_FF_addEH exit if the option is disabled (where the pop-ups and logging are), and the latter is the entry point for all FF checks so it wont trigger no matter what |
|
Opened #3060 as an issue for separate change request regarding the FF stuff. |
jaj22
approved these changes
Nov 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this.
What have you changed and why?
Updates parameters as readable in #3057
Please specify which Issue this PR Resolves.
closes #3057