Minimum distance check for AAF Road Patrol

[ante185]

What type of PR is this.

1. Bug
2. Change
3. Enhancement

What have you changed and why?

Information:
Filters out patrol starting locations that which have players within 350m

Please specify which Issue this PR Resolves.

Should close #2589

Please verify the following and ensure all checks are completed.

1. Have you loaded the mission in LAN host?
2. Have you loaded the mission on a dedicated server?

Is further testing or are further changes required?

1. No
2. Yes (Please provide further detail below.)

How can the changes be tested?

Steps:
Run "[] spawn A3A_fnc_AAFroadPatrol" when close and further away from a valid location.
Changes:
the check for players distance may need to be increased as 250 350 might be a little short.

---

Notes:
The hard limit on tries is something i admit i feel dubious about, it is probably fine as is.
Because of the exitWith if _startBases is empty it cannot go into a infinite loop, _limit only exists as a performance save.

[jaj22]

Better to add the inAreaArray as a one-liner to the select at around line 17 instead, as that's already condition-filtering. I feel like there was a reason why I didn't do that earlier but I was probably just being picky. Can rewrite it properly later anyway.

[ante185]

Better to add the inAreaArray as a one-liner to the select at around line 17 instead, as that's already condition-filtering. I feel like there was a reason why I didn't do that earlier but I was probably just being picky. Can rewrite it properly later anyway.

From what i understand the code _bases is used for both as starting locations and locations that the patrol will visit, so putting the check up there at 17 would exclude outposts and locations that the player is at from being visited

[jaj22]

I've checked. _bases isn't touched after the selectRandom. Patrol destinations are generated separately by feeding A3A_fnc_patrolDestinations with all markers of the patrolling side. So no reason why the one-liner wouldn't work.

Ideally the origin base check includes non-player spawners and doesn't include airborne units. Could probably be a bit larger too, although there's no path check so there's some risk of ending up on the wrong island.

[ante185]

Changed to a one line filter

[jaj22]

Would have split that into two ifs, but it'll do for now. Function needs a lot of work later anyway.