Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vehiclesLightTanks template category #2960

Merged

Conversation

jaj22
Copy link

@jaj22 jaj22 commented Oct 6, 2023

What type of PR is this.

  1. Bug
  2. Change
  3. Enhancement

What have you changed and why?

Added a light tanks category for vehicles with similar firepower to an IFV but no passenger space. Most templates won't need it but SPE-IFA does for the M18 Hellcat, and some others would benefit (most of the VN tanks are probably overvalued, for example).

Please specify which Issue this PR Resolves.

closes #XXXX

Please verify the following and ensure all checks are completed.

  1. Have you loaded the mission in LAN host?
  2. Have you loaded the mission on a dedicated server?

Is further testing or are further changes required?

  1. No
  2. Yes (Please provide further detail below.)

I didn't actually use the new category yet. Some stuff won't really be tested until then.

@jaj22 jaj22 added the Enhancement New feature or request label Oct 6, 2023
@jaj22 jaj22 added this to the 3.4 milestone Oct 6, 2023
Copy link

@Bob-Murphy Bob-Murphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Bob-Murphy Bob-Murphy merged commit bc54be1 into official-antistasi-community:unstable Oct 7, 2023
@Bob-Murphy Bob-Murphy added the Added to changelog Added to changelog label Nov 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Added to changelog Added to changelog Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants