forked from Bob-Murphy/A3-Antistasi-1.4
-
-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vanilla DLC & WS CDLC Vehicles #2931
Merged
Bob-Murphy
merged 11 commits into
official-antistasi-community:unstable
from
ante185:Vanilla-DLC-Vehicles
Sep 24, 2023
Merged
Vanilla DLC & WS CDLC Vehicles #2931
Bob-Murphy
merged 11 commits into
official-antistasi-community:unstable
from
ante185:Vanilla-DLC-Vehicles
Sep 24, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This does not only add Vanilla DLC content but also adds Western Sahara CDLC content. |
Bob-Murphy
requested changes
Sep 23, 2023
A3A/addons/core/Templates/Templates/Vanilla/Vanilla_AI_NATO_Apex.sqf
Outdated
Show resolved
Hide resolved
A3A/addons/core/Templates/Templates/Vanilla/Vanilla_AI_NATO_Apex.sqf
Outdated
Show resolved
Hide resolved
A3A/addons/core/Templates/Templates/Vanilla/Vanilla_AI_CSAT_Temperate.sqf
Outdated
Show resolved
Hide resolved
A3A/addons/core/Templates/Templates/Vanilla/Vanilla_AI_NATO_Arid.sqf
Outdated
Show resolved
Hide resolved
A3A/addons/core/Templates/Templates/Vanilla/Vanilla_AI_NATO_Temperate.sqf
Outdated
Show resolved
Hide resolved
A3A/addons/core/Templates/Templates/Vanilla/Vanilla_AI_NATO_Temperate.sqf
Outdated
Show resolved
Hide resolved
A3A/addons/core/Templates/Templates/Vanilla/Vanilla_AI_NATO_Tropical.sqf
Outdated
Show resolved
Hide resolved
A3A/addons/core/Templates/Templates/Vanilla/Vanilla_AI_NATO_Tropical.sqf
Outdated
Show resolved
Hide resolved
Bob-Murphy
added
Change requested
A change has been requested, and this can't be merged until it's done.
and removed
Review pending
labels
Sep 23, 2023
Having them in the regular array would cause errors as the classnames do only exist while WS is loaded
in Vanilla_Reb_Vehicle_Attributes I moved the western sahara uparmoured offroads into a if statement based of whether western sahara is loaded or not, as these would cause errors otherwise. |
GMG likely hood should be sufficiently reduced/addressed now. |
Bob-Murphy
approved these changes
Sep 24, 2023
Bob-Murphy
approved these changes
Sep 24, 2023
Bob-Murphy
added
Ready for merge
and removed
Change requested
A change has been requested, and this can't be merged until it's done.
labels
Sep 24, 2023
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this.
What have you changed and why?
Information:
Adds DLC vehicles and the conditions for them
Please verify the following and ensure all checks are completed.
Is further testing or are further changes required?
How can the changes be tested?
Steps:
Notes: