Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vanilla DLC & WS CDLC Vehicles #2931

Merged

Conversation

ante185
Copy link

@ante185 ante185 commented Sep 6, 2023

What type of PR is this.

  1. Bug
  2. Change
  3. Enhancement

What have you changed and why?

Information:
Adds DLC vehicles and the conditions for them

Please verify the following and ensure all checks are completed.

  1. Have you loaded the mission in LAN host?
  2. Have you loaded the mission on a dedicated server?

Is further testing or are further changes required?

  1. No
  2. Yes (Please provide further detail below.)

How can the changes be tested?

Steps:


Notes:

@ante185 ante185 marked this pull request as ready for review September 7, 2023 19:46
@Bob-Murphy Bob-Murphy added Review pending Templates Items related to templates labels Sep 15, 2023
@Bob-Murphy Bob-Murphy requested a review from Lazejun September 15, 2023 09:45
@Bob-Murphy
Copy link

This does not only add Vanilla DLC content but also adds Western Sahara CDLC content.

@Bob-Murphy Bob-Murphy added Change requested A change has been requested, and this can't be merged until it's done. and removed Review pending labels Sep 23, 2023
@Bob-Murphy Bob-Murphy added this to the 3.4 milestone Sep 23, 2023
Having them in the regular array would cause errors as the classnames do only  exist while WS is loaded
@ante185 ante185 changed the title Vanilla DLC Vehicles Vanilla DLC & WS CDLC Vehicles Sep 24, 2023
@ante185
Copy link
Author

ante185 commented Sep 24, 2023

in Vanilla_Reb_Vehicle_Attributes I moved the western sahara uparmoured offroads into a if statement based of whether western sahara is loaded or not, as these would cause errors otherwise.

@ante185
Copy link
Author

ante185 commented Sep 24, 2023

GMG likely hood should be sufficiently reduced/addressed now.
1 in 3 for vanilla, 1 in 5 with apex enabled.

@Bob-Murphy Bob-Murphy added Ready for merge and removed Change requested A change has been requested, and this can't be merged until it's done. labels Sep 24, 2023
@Bob-Murphy Bob-Murphy merged commit 9489fd5 into official-antistasi-community:unstable Sep 24, 2023
@Bob-Murphy Bob-Murphy added the Added to changelog Added to changelog label Nov 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Added to changelog Added to changelog Ready for merge Templates Items related to templates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants