Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PATCOM Garrisons minor fixes and adjustments #2876

Merged

Conversation

MeltedPixel
Copy link

@MeltedPixel MeltedPixel commented Jul 29, 2023

What type of PR is this.

  1. Bug
  2. Change
  3. Enhancement

What have you changed and why?

Information:
Changed how garrison units are distributed to buildings. Instead of filling up all building positions and then moving to the next building in the list, the script now takes the amount of garrison-able buildings and units and distributes them evenly with a defined minimum allowed in each building.

Changes how finding garrison-able buildings functions. Instead of it being a one or the other choice, it now just uses the A3A building blacklist and checks for pre-defined building positions in the whitelist. If pre-defined positions are not found, we use the default ones and randomize.

Please verify the following and ensure all checks are completed.

  1. Have you loaded the mission in LAN host?
  2. Have you loaded the mission on a dedicated server?

Is further testing or are further changes required?

  1. No
  2. Yes (Please provide further detail below.)

How can the changes be tested?

Steps:


Notes:

Should fix, #2810

@MeltedPixel MeltedPixel added Change A change to existing functionality Enhancement New feature or request labels Jul 29, 2023
@MeltedPixel
Copy link
Author

It doesn't specifically close #2869, but it does sorta mesh with it.

Copy link

@jaj22 jaj22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like good changes. Made a couple of optional notes.

@MeltedPixel MeltedPixel added this to the 3.4 milestone Aug 3, 2023
@ante185
Copy link

ante185 commented Aug 6, 2023

image
this seems to happen much more reliably with this. Presumably because all the building-units don't end up all in the same building?

@Bob-Murphy Bob-Murphy self-requested a review August 9, 2023 10:05
@Bob-Murphy
Copy link

Will check next week

Copy link

@jaj22 jaj22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@MeltedPixel
Copy link
Author

image
Ignore little guy close to the static in the building. He was running to arm it, but did not spawn close to it.

@ante185
Copy link

ante185 commented Aug 21, 2023

image
image
image
tried this out on my isla duala port, and the stuff looks great!
It seems to be decent at putting the garrison in either good overwatch location or at unexpecting angles, some positions are less than ideal but with the units spread out it's less of a big deal (No more wiping a resource or factory with a single nade into a warehouse)

Perhaps a little bit of a bias towards small buildings, but i suppose that's inevitable/unsolvable

Copy link

@rautamiekka rautamiekka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Capitalization fix.

@Bob-Murphy Bob-Murphy merged commit 50c27ca into official-antistasi-community:unstable Aug 27, 2023
@Bob-Murphy Bob-Murphy added the Added to changelog Added to changelog label Nov 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Added to changelog Added to changelog Change A change to existing functionality Enhancement New feature or request Ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants