-
-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PATCOM Garrisons minor fixes and adjustments #2876
PATCOM Garrisons minor fixes and adjustments #2876
Conversation
It doesn't specifically close #2869, but it does sorta mesh with it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like good changes. Made a couple of optional notes.
Will check next week |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Capitalization fix.
Co-authored-by: Jouni Järvinen <[email protected]>
What type of PR is this.
What have you changed and why?
Information:
Changed how garrison units are distributed to buildings. Instead of filling up all building positions and then moving to the next building in the list, the script now takes the amount of garrison-able buildings and units and distributes them evenly with a defined minimum allowed in each building.
Changes how finding garrison-able buildings functions. Instead of it being a one or the other choice, it now just uses the A3A building blacklist and checks for pre-defined building positions in the whitelist. If pre-defined positions are not found, we use the default ones and randomize.
Please verify the following and ensure all checks are completed.
Is further testing or are further changes required?
How can the changes be tested?
Steps:
Notes:
Should fix, #2810