Add member & guest lock limits to garage #2829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok, ran out of plausible ideas for the dialog/hint rendering order problem, so I'll have to bench this for now. |
killerswin2
approved these changes
Sep 2, 2023
killerswin2
added
Ready for merge
and removed
Info needed
Bob-Murphy
requested changes
Sep 3, 2023
Bob-Murphy
added
Change requested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this.
What have you changed and why?
Heavily-requested community feature. Adds CBA-configurable member and guest limits to garage vehicle locks. It ignores source vehicles, as they are effectively public resources that should be managed by the commander.
Issue that needs resolving: Garage is currently rendered on top of customHint. Not sure why yet.
Please specify which Issue this PR Resolves.
closes #2823
Please verify the following and ensure all checks are completed.
Is further testing or are further changes required?
Need to fix the UI rendering order issue.