Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tsam to datapackage #141

Draft
wants to merge 24 commits into
base: dev
Choose a base branch
from
Draft

Add tsam to datapackage #141

wants to merge 24 commits into from

Conversation

nailend
Copy link
Collaborator

@nailend nailend commented Nov 10, 2023 •
edited
Loading

Description

Tsam option is now available for tabular reading module, but only for multi-period approach.
Parameters need to be provided by two separate csvs.

  • tsa_paramters (period, timesteps_per_period, order)

  • add example

  • adjust timeseries data of example

Fixes #138

Type of change

Please tick or delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

Please tick or delete options that are not relevant.

  • New and adjusted code is formatted using the pre-commit hooks
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have added new features/fixes to the CHANGELOG

@nailend nailend linked an issue Nov 10, 2023 that may be closed by this pull request
Add TSAM config to datapackage #138
Open
@nailend nailend requested a review from henhuy November 10, 2023 16:02
henhuy
henhuy reviewed Nov 13, 2023
View reviewed changes
Copy link
Collaborator

@henhuy henhuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Structure in datapackage looks good to me!

But I have failing tests on my side:

  • test_example_datapackage_readability
  • test_scripting_examples
  • test_examples_datapackages_scripts_infer

Do the tests also fail on your side?

@henhuy
Copy link
Collaborator

henhuy commented Nov 13, 2023

Why did yo mark it as "breaking change"? IMO, this should not interfere with older tabular versions?!

@nailend
Copy link
Collaborator Author

nailend commented Nov 13, 2023

Why did yo mark it as "breaking change"? IMO, this should not interfere with older tabular versions?!

I guess, I slipped...

Do the tests also fail on your side?

yes, I still have to adjust the component timeseries.

@nailend nailend self-assigned this Dec 4, 2023
@nailend nailend added the enhancement New feature or request label Dec 4, 2023
@nailend nailend requested a review from henhuy December 5, 2023 21:07
henhuy
henhuy requested changes Dec 6, 2023
View reviewed changes
Copy link
Collaborator

@henhuy henhuy left a comment •
edited by FelixMau
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When looking into TSAm parameters of example datapackage "dispatch_multi_period_tsam", I found that third period has an invalid order (containing 3 different typical periods, which would sum up to 6 timesteps in third period, but only 4 are given) which must normally lead to an error when building energysystem. Thus, I wondered why no error is thrown - on my side, this was due to wrong oemof.solph version (one which does not include TSAM parameters - so that they are neglected when building ES ergo no error is thrown). Updating oemof.solph, pointing to branch feature/integrate_tsam unfortunately lead to dependency issues as oemof.networkand oemof.tools versions are not correctly pinned in oemof.solph. After manually fixing those versions, I finally could see the error resulting from invalid TSAM parameters - but unfurtunately, now I can see multiple other errors in other tests (regarding wrong LP-files and stuff).
I think, in order to finalize this PR, we should do following:

  • fix dependencies in oemof.solph
  • fix TSAM parameters in example
  • look into errors from other tests and check if they belong into this PR or have to be adapted in other PR (as bringing oemof.tabular in line with latest oemof.solph version)

@FelixMau
Copy link
Collaborator

FelixMau commented Jan 30, 2024 •
edited
Loading

Regarding changed LP files please see #155

@FelixMau
Solph dependency
4bcbfb0
@FelixMau
Merge remote-tracking branch 'origin/features/add-tsam-to-datapackage…
a7e9548 
…' into features/add-tsam-to-datapackage

# Conflicts:
#	setup.py
@FelixMau
Merge branch 'dev' into features/add-tsam-to-datapackage
7034337 
# Conflicts:
#	setup.py
#	src/oemof/tabular/datapackage/reading.py
@FelixMau FelixMau requested a review from henhuy February 7, 2024 14:54
@FelixMau FelixMau self-assigned this Feb 7, 2024
@nailend nailend marked this pull request as draft February 23, 2024 16:05
@nailend
Copy link
Collaborator Author

nailend commented Feb 23, 2024 •
edited
Loading

This will only be merged after tsam-branch in solph is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henhuy henhuy Awaiting requested review from henhuy

Assignees

@nailend nailend

@FelixMau FelixMau

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add TSAM config to datapackage
3 participants
@nailend @henhuy @FelixMau