Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: MultiPeriodConstraint tests fail upgrading solph 0.5.2dev0 to 0.5.2dev1 #155

Closed
FelixMau opened this issue Jan 30, 2024 · 2 comments · Fixed by #157
Closed

Bug: MultiPeriodConstraint tests fail upgrading solph 0.5.2dev0 to 0.5.2dev1 #155

FelixMau opened this issue Jan 30, 2024 · 2 comments · Fixed by #157
Assignees

Comments

@FelixMau
Copy link
Collaborator

FelixMau commented Jan 30, 2024

Tests fail for MultiPeriodConstraints (figures in LP files change for some values)

Tests fails too when using oemof.solph-0.5.3a1. With exactly the same Errors in same tests.

Apparently tests only work with solph 0.5.2dev0

To find the Bug I have been running tests with different settings (S for Success and F for failure);

Version solph 0.5.2 solph 0.5.2dev0 solph 0.5.2dev1 solph 0.5.3a1 solph /feature/integrate_tsam
tabular tsam F S F F F
tabular dev F S F F F

Then I went to check on changes in oemof.solph from 0.5.2dev0 towards 0.5.2dev1 and examined different commits.
Breaking commit seems to be an update to docstrings which appears very (very) weird to me.

@FelixMau
Copy link
Collaborator Author

FelixMau commented Jan 31, 2024

After Updating Pycharm (thanks for tipp @henhuy) and properly tracking branches. Found out that (of course) not the change in Docstrings is breaking but accounting for ramainging values of multi period investments.

Since also within solph the LP files have been updated we should check our LP files as well and upgrade them eventually.
At first sight the pattern of changes applied to solph LP files fits differences observed in tabular LP file changes.

@FelixMau
Copy link
Collaborator Author

FelixMau commented Feb 7, 2024

Upgrade to oemof.solph 0.5.2dev2 includes update of LP files leading to succesfully running tests!

@FelixMau FelixMau linked a pull request Feb 7, 2024 that will close this issue
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants