Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FW][REV] collaborative: always trigger collaborative event received #5477

Closed

Conversation

fw-bot
Copy link
Collaborator

@fw-bot fw-bot commented Jan 14, 2025

In commit 30e1e37, we removed the bus signal when receiving the server response of our own message but that feature can be useful to evaluate the connection status with the said-server. This is used in our integration within Odoo.

Task: 0

Description:

description of this task, what is implemented and why it is implemented that way.

Task: TASK_ID

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

Forward-Port-Of: #5475

In commit 30e1e37, we removed the bus signal when receiving the
server response of our own message but that feature can be useful
to evaluate the connection status with the said-server.
This is used in our integration within Odoo.

Task: 0
X-original-commit: 5c945f6
@robodoo
Copy link
Collaborator

robodoo commented Jan 14, 2025

Pull request status dashboard

@fw-bot
Copy link
Collaborator Author

fw-bot commented Jan 14, 2025

This PR targets 18.0 and is part of the forward-port chain. Further PRs will be created up to master.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants