Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REV] collaborative: always trigger collaborative event received #5475

Closed
wants to merge 1 commit into from

Conversation

rrahir
Copy link
Collaborator

@rrahir rrahir commented Jan 14, 2025

In commit 30e1e37, we removed the bus signal when receiving the server response of our own message but that feature can be useful to evaluate the connection status with the said-server. This is used in our integration within Odoo.

Task: 0

Description:

description of this task, what is implemented and why it is implemented that way.

Task: TASK_ID

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

@robodoo
Copy link
Collaborator

robodoo commented Jan 14, 2025

Pull request status dashboard

In commit 30e1e37, we removed the bus signal when receiving the
server response of our own message but that feature can be useful
to evaluate the connection status with the said-server.
This is used in our integration within Odoo.

Task: 0
@rrahir rrahir force-pushed the saas-17.2-rev-collab-no-trigger-rar branch from e538117 to 5e98633 Compare January 14, 2025 14:24
@VincentSchippefilt
Copy link
Collaborator

robodoo r+

robodoo pushed a commit that referenced this pull request Jan 14, 2025
In commit 30e1e37, we removed the bus signal when receiving the
server response of our own message but that feature can be useful
to evaluate the connection status with the said-server.
This is used in our integration within Odoo.

closes #5475

Task: 0
Signed-off-by: Vincent Schippefilt (vsc) <[email protected]>
@robodoo robodoo closed this Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants