[FW] Master xlsx tests wait lul #5170
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We no longer have async functions since at least 3 years and the `WAIT` function was removed when we removed async function support. This commit removes the test. The following commit adapts other tests using the `wait` function. Task: 4306250 X-original-commit: ec41486
";" isn't a valid separator. Task: 4306250 X-original-commit: 70f58fa
The `WAIT` function no longer exists. It has been removed several years ago when async function support was removed. This commit adapts the tests using to use other functions. Note that 2 tests had their data wrongly defined where the `A2` was a child of the `A1` object instead of being its neighbour. Task: 4306250 X-original-commit: 262b1bc
|
|
|
@LucasLefevre @pro-odoo this PR targets master and is the last of the forward-port chain. To merge the full chain, use
More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
|
robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Nov 7, 2024
We no longer have async functions since at least 3 years and the `WAIT` function was removed when we removed async function support. This commit removes the test. The following commit adapts other tests using the `wait` function. Task: 4306250 X-original-commit: ec41486 Part-of: #5170 Signed-off-by: Pierre Rousseau (pro) <[email protected]>
robodoo
pushed a commit
that referenced
this pull request
Nov 7, 2024
";" isn't a valid separator. Task: 4306250 X-original-commit: 70f58fa Part-of: #5170 Signed-off-by: Pierre Rousseau (pro) <[email protected]>
robodoo
pushed a commit
that referenced
this pull request
Nov 7, 2024
The `WAIT` function no longer exists. It has been removed several years ago when async function support was removed. This commit adapts the tests using to use other functions. Note that 2 tests had their data wrongly defined where the `A2` was a child of the `A1` object instead of being its neighbour. closes #5170 Task: 4306250 X-original-commit: 262b1bc Signed-off-by: Pierre Rousseau (pro) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
description of this task, what is implemented and why it is implemented that way.
Task: TASK_ID
review checklist
Forward-Port-Of: #5155