Master xlsx tests wait lul #5155
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
LucasLefevre
force-pushed
the
master-xlsx-tests-wait-lul
branch
5 times, most recently
from
9da3bca to
65634cb
Compare
We no longer have async functions since at least 3 years and the `WAIT` function was removed when we removed async function support. This commit removes the test. The following commit adapts other tests using the `wait` function. Task: 4306250
";" isn't a valid separator. Task: 4306250
The `WAIT` function no longer exists. It has been removed several years ago when async function support was removed. This commit adapts the tests using to use other functions. Note that 2 tests had their data wrongly defined where the `A2` was a child of the `A1` object instead of being its neighbour. Task: 4306250
LucasLefevre
force-pushed
the
master-xlsx-tests-wait-lul
branch
from
65634cb to
388b12b
Compare
|
@LucasLefevre @pro-odoo because this PR has multiple commits, I need to know how to merge it:
|
|
robodoo rebase-ff |
|
Merge method set to rebase and fast-forward. |
robodoo
pushed a commit
that referenced
this pull request
Nov 7, 2024
We no longer have async functions since at least 3 years and the `WAIT` function was removed when we removed async function support. This commit removes the test. The following commit adapts other tests using the `wait` function. Task: 4306250 Part-of: #5155 Signed-off-by: Pierre Rousseau (pro) <[email protected]>
robodoo
pushed a commit
that referenced
this pull request
Nov 7, 2024
";" isn't a valid separator. Task: 4306250 Part-of: #5155 Signed-off-by: Pierre Rousseau (pro) <[email protected]>
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
description of this task, what is implemented and why it is implemented that way.
Task: TASK_ID
review checklist