[FW][FIX] Charts: Fix tooltip value when data is zero #5128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following a refactoring of the charts, the tooltip would not display the data value when the data equalled zero. How to reproduce: - generate a line graph such that one of the dataset points is 0 - Hover the said data point -> the tooltip will read something along "Series 1:" and no value afterwards. Task: 4251681 X-original-commit: 9f337f3
|
|
|
@rrahir @pro-odoo this PR targets master and is the last of the forward-port chain. To merge the full chain, use
More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
|
robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Oct 24, 2024
Following a refactoring of the charts, the tooltip would not display the data value when the data equalled zero. How to reproduce: - generate a line graph such that one of the dataset points is 0 - Hover the said data point -> the tooltip will read something along "Series 1:" and no value afterwards. closes #5128 Task: 4251681 X-original-commit: 9f337f3 Signed-off-by: Pierre Rousseau (pro) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following a refactoring of the charts, the tooltip would not display the data value when the data equalled zero.
How to reproduce:
-> the tooltip will read something along "Series 1:" and no value afterwards.
Task: 4251681
Description:
description of this task, what is implemented and why it is implemented that way.
Task: TASK_ID
review checklist
Forward-Port-Of: #5127
Forward-Port-Of: #5094