Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FW][FIX] Charts: Fix tooltip value when data is zero #5127

Closed
wants to merge 1 commit into from

Conversation

fw-bot
Copy link
Collaborator

@fw-bot fw-bot commented Oct 24, 2024

Following a refactoring of the charts, the tooltip would not display the data value when the data equalled zero.

How to reproduce:

  • generate a line graph such that one of the dataset points is 0
  • Hover the said data point

-> the tooltip will read something along "Series 1:" and no value afterwards.

Task: 4251681

Description:

description of this task, what is implemented and why it is implemented that way.

Task: TASK_ID

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

Forward-Port-Of: #5094

@robodoo
Copy link
Collaborator

robodoo commented Oct 24, 2024

Pull request status dashboard

@fw-bot
Copy link
Collaborator Author

fw-bot commented Oct 24, 2024

@rrahir @pro-odoo cherrypicking of pull request #5094 failed.

stdout:

Auto-merging src/helpers/figures/charts/chart_ui_common.ts
Auto-merging tests/figures/chart/chart_plugin.test.ts
CONFLICT (content): Merge conflict in tests/figures/chart/chart_plugin.test.ts

Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?).

In the former case, you may want to edit this PR message as well.

⚠️ after resolving this conflict, you will need to merge it via @robodoo.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

Following a refactoring of the charts, the tooltip would not display the
data value when the data equalled zero.

How to reproduce:
- generate a line graph such that one of the dataset points is 0
- Hover the said data point

-> the tooltip will read something along "Series 1:" and no value
afterwards.

Task: 4251681
X-original-commit: ec02c46
@pro-odoo pro-odoo force-pushed the 18.0-saas-17.4-fix-zero-value-label-rar-pau5-fw branch from 19feb72 to e10de6d Compare October 24, 2024 08:05
@pro-odoo
Copy link
Collaborator

robodoo r+

@robodoo robodoo closed this in 9f337f3 Oct 24, 2024
@fw-bot fw-bot deleted the 18.0-saas-17.4-fix-zero-value-label-rar-pau5-fw branch November 7, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants