Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FW][FIX] evaluation: add a getter to evaluate value and format #4806

Closed

Conversation

fw-bot
Copy link
Collaborator

@fw-bot fw-bot commented Aug 9, 2024

Description:

This commit introduces a new getter evaluateFormulaResult which is equivalent to the existing evaluateFormula but returns the value and the format instead of just the value.

Task: : 4102210

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

Forward-Port-Of: #4804
Forward-Port-Of: #4785

@robodoo
Copy link
Collaborator

robodoo commented Aug 9, 2024

Pull request status dashboard

@fw-bot
Copy link
Collaborator Author

fw-bot commented Aug 9, 2024

@LucasLefevre @rrahir cherrypicking of pull request #4785 failed.

stdout:

Auto-merging src/plugins/ui_core_views/cell_evaluation/evaluation_plugin.ts
CONFLICT (content): Merge conflict in src/plugins/ui_core_views/cell_evaluation/evaluation_plugin.ts
Auto-merging src/plugins/ui_core_views/cell_evaluation/evaluator.ts
CONFLICT (content): Merge conflict in src/plugins/ui_core_views/cell_evaluation/evaluator.ts

Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?).

In the former case, you may want to edit this PR message as well.

⚠️ after resolving this conflict, you will need to merge it via @robodoo.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

@rrahir rrahir force-pushed the master-17.0-evaluate-formula-result-lul-qDjz-fw branch from 0e6ed45 to 2fd7aa5 Compare August 9, 2024 11:42
@LucasLefevre LucasLefevre force-pushed the master-17.0-evaluate-formula-result-lul-qDjz-fw branch from 2fd7aa5 to 4ccc8b7 Compare August 9, 2024 11:44
Copy link
Collaborator

@LucasLefevre LucasLefevre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

robodoo r+

@robodoo
Copy link
Collaborator

robodoo commented Aug 9, 2024

@LucasLefevre you may want to rebuild or fix this PR as it has failed CI.

@LucasLefevre LucasLefevre force-pushed the master-17.0-evaluate-formula-result-lul-qDjz-fw branch from 4ccc8b7 to 600e833 Compare August 9, 2024 11:52
@LucasLefevre
Copy link
Collaborator

robodoo r+

This commit introduces a new getter `evaluateFormulaResult` which
is equivalent to the existing `evaluateFormula` but returns the
value and the format instead of just the value.

Task: 4102210
X-original-commit: a5da70a
@rrahir rrahir force-pushed the master-17.0-evaluate-formula-result-lul-qDjz-fw branch from 600e833 to ba5ef80 Compare August 9, 2024 11:53
@LucasLefevre
Copy link
Collaborator

robodoo r+

robodoo pushed a commit that referenced this pull request Aug 9, 2024
This commit introduces a new getter `evaluateFormulaResult` which
is equivalent to the existing `evaluateFormula` but returns the
value and the format instead of just the value.

closes #4806

Task: 4102210
X-original-commit: a5da70a
Signed-off-by: Rémi Rahir (rar) <[email protected]>
Signed-off-by: Lucas Lefèvre (lul) <[email protected]>
@robodoo robodoo closed this Aug 9, 2024
@robodoo robodoo added the 17.5 label Aug 9, 2024
@fw-bot fw-bot deleted the master-17.0-evaluate-formula-result-lul-qDjz-fw branch August 23, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants