Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] evaluation: add a getter to evaluate value and format #4785

Closed
wants to merge 1 commit into from

Conversation

LucasLefevre
Copy link
Collaborator

Description:

This commit introduces a new getter evaluateFormulaResult which is equivalent to the existing evaluateFormula but returns the value and the format instead of just the value.

Task: : 4102210

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

@robodoo
Copy link
Collaborator

robodoo commented Aug 7, 2024

Pull request status dashboard

@LucasLefevre LucasLefevre force-pushed the 17.0-evaluate-formula-result-lul branch from e9cd7db to 353ebb9 Compare August 8, 2024 07:11
This commit introduces a new getter `evaluateFormulaResult` which
is equivalent to the existing `evaluateFormula` but returns the
value and the format instead of just the value.

Task: 4102210
@LucasLefevre LucasLefevre force-pushed the 17.0-evaluate-formula-result-lul branch from 353ebb9 to 4df2e60 Compare August 8, 2024 07:13
@rrahir
Copy link
Collaborator

rrahir commented Aug 9, 2024

@robodoo r+

robodoo pushed a commit that referenced this pull request Aug 9, 2024
This commit introduces a new getter `evaluateFormulaResult` which
is equivalent to the existing `evaluateFormula` but returns the
value and the format instead of just the value.

closes #4785

Task: 4102210
Signed-off-by: Rémi Rahir (rar) <[email protected]>
@robodoo robodoo closed this Aug 9, 2024
@fw-bot fw-bot deleted the 17.0-evaluate-formula-result-lul branch August 23, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants