[FW][FIX] pivot: Prevent faulty pivot domain to crash #4805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@rrahir @LucasLefevre this PR targets master and is the last of the forward-port chain. To merge the full chain, use
More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
|
@rrahir @LucasLefevre ci/runbot failed on this forward-port PR |
|
robodoo r+
…On Fri, Aug 9, 2024 at 1:11 PM Otis - Odoo Forward-Port Steward [bot] < ***@***.***> wrote:
@rrahir <https://github.com/rrahir> @LucasLefevre
<https://github.com/LucasLefevre> this PR targets master and is the last
of the forward-port chain.
To merge the full chain, use
@robodoo <https://github.com/robodoo> r+
More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port
—
Reply to this email directly, view it on GitHub
<#4805 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACTHFEOY3BNQHNYNLG4TZADZQSPV5AVCNFSM6AAAAABMIIJHA6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENZXG4YTCNRZG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@LucasLefevre you may want to rebuild or fix this PR as it has failed CI. |
The getter `getPivotCellFromPosition` parses pivot cells domain args but this step assumes that the domain is valid (e.g. refers to a valid groupby,measure combination). Unfortunately, if the domain is invalid, the parsing will crash. Similarly to the decision made for the getter `evaluateFormula`[^1] we wrap the parsing in a try/catch statement and in case of faulty evaluation, return the same result as for invalid/non-existing pivots, that is an empty Pivotcell. [^1]: See #3371 Task: 4088765 X-original-commit: 693db2b
rrahir
force-pushed
the
master-saas-17.4-prevent-invalid-formula-domain-crash-rar-I1Ly-fw
branch
from
964403c to
50f714c
Compare
|
@robodoo r+ |
|
@rrahir @LucasLefevre this PR was modified / updated and has become a normal PR. It must be merged directly. |
robodoo
pushed a commit
that referenced
this pull request
Aug 9, 2024
The getter `getPivotCellFromPosition` parses pivot cells domain args but this step assumes that the domain is valid (e.g. refers to a valid groupby,measure combination). Unfortunately, if the domain is invalid, the parsing will crash. Similarly to the decision made for the getter `evaluateFormula`[^1] we wrap the parsing in a try/catch statement and in case of faulty evaluation, return the same result as for invalid/non-existing pivots, that is an empty Pivotcell. [^1]: See #3371 closes #4805 Task: 4088765 X-original-commit: 693db2b Signed-off-by: Lucas Lefèvre (lul) <[email protected]> Signed-off-by: Rémi Rahir (rar) <[email protected]>
fw-bot
deleted the
master-saas-17.4-prevent-invalid-formula-domain-crash-rar-I1Ly-fw
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The getter
getPivotCellFromPositionparses pivot cells domain args but this step assumes that the domain is valid (e.g. refers to a valid groupby,measure combination). Unfortunately, if the domain is invalid, the parsing will crash.Similarly to the decision made for the getter
evaluateFormula1 we wrap the parsing in a try/catch statement and in case of faulty evaluation, return the same result as for invalid/non-existing pivots, that is an empty Pivotcell.Task: 4088765
Description:
description of this task, what is implemented and why it is implemented that way.
Task: : TASK_ID
review checklist
Forward-Port-Of: #4741
Footnotes
See https://github.com/odoo/o-spreadsheet/pull/3371 ↩