[IMP] evaluation: evaluateFormula no longer throws
#3371
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LucasLefevre
reviewed
Jan 3, 2024
| @@ -188,7 +184,7 @@ export class EvaluationConditionalFormatPlugin extends UIPlugin { | |||
| return percentile(rangeValues, Number(threshold.value) / 100, true); | |||
| case "formula": | |||
| const value = threshold.value && this.getters.evaluateFormula(threshold.value); | |||
| return !(value instanceof Promise) ? value : null; | |||
| return typeof value == "number" ? value : null; | |||
There was a problem hiding this comment.
this is a behavior change, right ?
Technically, value could be a string before (even if it should not according to the method return type).
Are we missing a test where the formula evaluates to a string ?
| @@ -380,7 +376,7 @@ export class EvaluationConditionalFormatPlugin extends UIPlugin { | |||
| if (cell && cell.evaluated.type === CellValueType.error) { | |||
| return false; | |||
| } | |||
| const values = rule.values.map(parsePrimitiveContent); | |||
| const values = rule.values?.map(parsePrimitiveContent) || []; | |||
There was a problem hiding this comment.
is this necessary ? The type definition states that values is always defined. But maybe it's lying :p
There was a problem hiding this comment.
the data fed to Model unfortunately bypasses it :/. I feel like TS could warn me that the chaining ?. is unnecessary since values is always defined 🤔
rrahir
force-pushed
the
16.0-evaluateFormula-no-throw-rar
branch
from
810d949 to
ea6cd26
Compare
The getter `evaluateFormula` required to be wrapped in a try/catch statement to handle the evaluation errors but as this is quite error prone, we decided to change it to no longer throw. The getter will instead the value of the error that was previously thrown. Task: 3576149
rrahir
force-pushed
the
16.0-evaluateFormula-no-throw-rar
branch
from
ea6cd26 to
5627f50
Compare
robodoo
pushed a commit
that referenced
this pull request
Jan 4, 2024
The getter `evaluateFormula` required to be wrapped in a try/catch statement to handle the evaluation errors but as this is quite error prone, we decided to change it to no longer throw. The getter will instead the value of the error that was previously thrown. closes #3371 Task: 3576149 Signed-off-by: Lucas Lefèvre (lul) <[email protected]>
This was referenced Jan 4, 2024
rrahir
added a commit
that referenced
this pull request
Aug 1, 2024
The getter `getPivotCellFromPosition` parses pivot cells domain args but this step assumes that the domain is valid (e.g. refers to a valid groupby,measure combination). Unfortunately, if the domain is invalid, the parsing will crash. Similarly to the decision made for the getter `evaluateFormula`[^1] we wrap the parsing in a try/catch statement and in case of faulty evaluation, return the same result as for invalid/non-existing pivots, that is an empty Pivotcell. [^1]: See #3371 Task: 4088765
robodoo
pushed a commit
that referenced
this pull request
Aug 9, 2024
The getter `getPivotCellFromPosition` parses pivot cells domain args but this step assumes that the domain is valid (e.g. refers to a valid groupby,measure combination). Unfortunately, if the domain is invalid, the parsing will crash. Similarly to the decision made for the getter `evaluateFormula`[^1] we wrap the parsing in a try/catch statement and in case of faulty evaluation, return the same result as for invalid/non-existing pivots, that is an empty Pivotcell. [^1]: See #3371 closes #4741 Task: 4088765 Signed-off-by: Lucas Lefèvre (lul) <[email protected]>
fw-bot
pushed a commit
that referenced
this pull request
Aug 9, 2024
The getter `getPivotCellFromPosition` parses pivot cells domain args but this step assumes that the domain is valid (e.g. refers to a valid groupby,measure combination). Unfortunately, if the domain is invalid, the parsing will crash. Similarly to the decision made for the getter `evaluateFormula`[^1] we wrap the parsing in a try/catch statement and in case of faulty evaluation, return the same result as for invalid/non-existing pivots, that is an empty Pivotcell. [^1]: See #3371 Task: 4088765 X-original-commit: 693db2b
rrahir
added a commit
that referenced
this pull request
Aug 9, 2024
The getter `getPivotCellFromPosition` parses pivot cells domain args but this step assumes that the domain is valid (e.g. refers to a valid groupby,measure combination). Unfortunately, if the domain is invalid, the parsing will crash. Similarly to the decision made for the getter `evaluateFormula`[^1] we wrap the parsing in a try/catch statement and in case of faulty evaluation, return the same result as for invalid/non-existing pivots, that is an empty Pivotcell. [^1]: See #3371 Task: 4088765 X-original-commit: 693db2b
robodoo
pushed a commit
that referenced
this pull request
Aug 9, 2024
The getter `getPivotCellFromPosition` parses pivot cells domain args but this step assumes that the domain is valid (e.g. refers to a valid groupby,measure combination). Unfortunately, if the domain is invalid, the parsing will crash. Similarly to the decision made for the getter `evaluateFormula`[^1] we wrap the parsing in a try/catch statement and in case of faulty evaluation, return the same result as for invalid/non-existing pivots, that is an empty Pivotcell. [^1]: See #3371 closes #4805 Task: 4088765 X-original-commit: 693db2b Signed-off-by: Lucas Lefèvre (lul) <[email protected]> Signed-off-by: Rémi Rahir (rar) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The getter
evaluateFormularequired to be wrapped in a try/catch statement to handle the evaluation errors but as this is quite error prone, we decided to change it to no longer throw. The getter will instead the value of the error that was previously thrown.Task: 3576149
Description:
description of this task, what is implemented and why it is implemented that way.
Task: : TASK_ID
review checklist