Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FW][FIX] format: dispatch only once #4774

Conversation

fw-bot
Copy link
Collaborator

@fw-bot fw-bot commented Aug 6, 2024

Description:

Steps to reproduce:

  • select a huge zone with numbers
  • click on the "Increase decimal places" tool in the top bar

=> there's one dipatched command for each position in the zone, which can huge.

We want:

  • one dispatched command per format
  • positions grouped to a single zone if there are contiguous (a single big zone instead of many zones, each being actually a single position)

Issue introduced by 1b66725

Task: : 4091502

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

Forward-Port-Of: #4770

Steps to reproduce:
- select a huge zone with numbers
- click on the "Increase decimal places" tool in the top bar

=> there's one dipatched command for each position in the zone, which
can huge.

We want:
- one dispatched command per format
- positions grouped to a single zone if there are contiguous (a single big
  zone instead of many zones, each being actually a single position)

Issue introduced by 1b66725

Task: 4091502
X-original-commit: f9611f7
@robodoo
Copy link
Collaborator

robodoo commented Aug 6, 2024

Pull request status dashboard

@fw-bot
Copy link
Collaborator Author

fw-bot commented Aug 6, 2024

This PR targets saas-17.1 and is part of the forward-port chain. Further PRs will be created up to master.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

robodoo pushed a commit that referenced this pull request Aug 6, 2024
Steps to reproduce:
- select a huge zone with numbers
- click on the "Increase decimal places" tool in the top bar

=> there's one dipatched command for each position in the zone, which
can huge.

We want:
- one dispatched command per format
- positions grouped to a single zone if there are contiguous (a single big
  zone instead of many zones, each being actually a single position)

Issue introduced by 1b66725

closes #4774

Task: 4091502
X-original-commit: f9611f7
Signed-off-by: Rémi Rahir (rar) <[email protected]>
@robodoo robodoo closed this Aug 6, 2024
@fw-bot fw-bot deleted the saas-17.1-17.0-set-decimal-single-dispatch-lul-pAIR-fw branch August 20, 2024 10:46
Topdev97 added a commit to Topdev97/o-spreadsheet that referenced this pull request Nov 18, 2024
Steps to reproduce:
- select a huge zone with numbers
- click on the "Increase decimal places" tool in the top bar

=> there's one dipatched command for each position in the zone, which
can huge.

We want:
- one dispatched command per format
- positions grouped to a single zone if there are contiguous (a single big
  zone instead of many zones, each being actually a single position)

Issue introduced by 1b667256cc386e4b8e8ff2e216e66bd9b9a03d62

closes odoo/o-spreadsheet#4774

Task: 4091502
X-original-commit: f9611f7345e1c6ce7add89c7176b3c10e2ea6cd1
Signed-off-by: Rémi Rahir (rar) <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants