[FIX] format: dispatch only once #4770
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
LucasLefevre
force-pushed
the
17.0-set-decimal-single-dispatch-lul
branch
from
fc3e994 to
3fa914c
Compare
Steps to reproduce: - select a huge zone with numbers - click on the "Increase decimal places" tool in the top bar => there's one dipatched command for each position in the zone, which can huge. We want: - one dispatched command per format - positions grouped to a single zone if there are contiguous (a single big zone instead of many zones, each being actually a single position) Issue introduced by 1b66725 Task: 4091502
LucasLefevre
force-pushed
the
17.0-set-decimal-single-dispatch-lul
branch
from
3fa914c to
26a379a
Compare
|
@robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Aug 6, 2024
Steps to reproduce: - select a huge zone with numbers - click on the "Increase decimal places" tool in the top bar => there's one dipatched command for each position in the zone, which can huge. We want: - one dispatched command per format - positions grouped to a single zone if there are contiguous (a single big zone instead of many zones, each being actually a single position) Issue introduced by 1b66725 closes #4770 Task: 4091502 Signed-off-by: Rémi Rahir (rar) <[email protected]>
This was referenced Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Steps to reproduce:
=> there's one dipatched command for each position in the zone, which can huge.
We want:
Issue introduced by 1b66725
Task: : 4091502
review checklist