Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FW][FIX] ranges: getRangeFromSheetXC with invalid sheetId #4773

Closed
wants to merge 1 commit into from

Conversation

fw-bot
Copy link
Collaborator

@fw-bot fw-bot commented Aug 6, 2024

Description

When getRangeFromSheetXC is called, it either crashes or returns an corrupted range. The getter should handle this case, and return an invalid range.

Task: : 3578461

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

Forward-Port-Of: #4275

@robodoo
Copy link
Collaborator

robodoo commented Aug 6, 2024

Pull request status dashboard

@fw-bot
Copy link
Collaborator Author

fw-bot commented Aug 6, 2024

@hokolomopo @rrahir cherrypicking of pull request #4275 failed.

stdout:

Auto-merging src/plugins/core/range.ts
Auto-merging tests/plugins/range.test.ts
CONFLICT (content): Merge conflict in tests/plugins/range.test.ts

Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?).

In the former case, you may want to edit this PR message as well.

⚠️ after resolving this conflict, you will need to merge it via @robodoo.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

When `getRangeFromSheetXC` is called, it either crashes or returns an
corrupted range. The getter should handle this case, and return an
invalid range.

Task: 3578461
@hokolomopo hokolomopo force-pushed the 17.0-16.0-getrangefromsheetxc-fix-adrm-mXpW-fw branch from 40290c8 to 982a739 Compare August 6, 2024 07:52
@hokolomopo
Copy link
Contributor

@robodoo r+

robodoo pushed a commit that referenced this pull request Aug 6, 2024
When `getRangeFromSheetXC` is called, it either crashes or returns an
corrupted range. The getter should handle this case, and return an
invalid range.

closes #4773

Task: 3578461
Signed-off-by: Rémi Rahir (rar) <[email protected]>
Signed-off-by: Adrien Minne (adrm) <[email protected]>
@robodoo robodoo closed this Aug 6, 2024
@fw-bot fw-bot deleted the 17.0-16.0-getrangefromsheetxc-fix-adrm-mXpW-fw branch August 20, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants