Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] ranges: getRangeFromSheetXC with invalid sheetId #4275

Closed
wants to merge 1 commit into from
Closed

[FIX] ranges: getRangeFromSheetXC with invalid sheetId #4275

wants to merge 1 commit into from

Conversation

hokolomopo
Copy link
Contributor

Description

When getRangeFromSheetXC is called, it either crashes or returns an corrupted range. The getter should handle this case, and return an invalid range.

Task: : 3578461

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

@robodoo
Copy link
Collaborator

robodoo commented May 27, 2024

Pull request status dashboard.

@hokolomopo @rrahir
[FIX] ranges: getRangeFromSheetXC with invalid sheetId
566b5f5 
When `getRangeFromSheetXC` is called, it either crashes or returns an
corrupted range. The getter should handle this case, and return an
invalid range.

Task: 3578461
@rrahir rrahir force-pushed the 16.0-getrangefromsheetxc-fix-adrm branch from 84218ce to 566b5f5 Compare August 6, 2024 06:27
@rrahir
Copy link
Collaborator

rrahir commented Aug 6, 2024

@robodoo r+

robodoo pushed a commit that referenced this pull request Aug 6, 2024
@hokolomopo @rrahir
[FIX] ranges: getRangeFromSheetXC with invalid sheetId
d1f5899 
When `getRangeFromSheetXC` is called, it either crashes or returns an
corrupted range. The getter should handle this case, and return an
invalid range.

closes #4275

Task: 3578461
Signed-off-by: Rémi Rahir (rar) <[email protected]>
@robodoo robodoo closed this Aug 6, 2024
This was referenced Aug 6, 2024
Closed
Closed
Closed
Closed
Closed
@fw-bot fw-bot deleted the 16.0-getrangefromsheetxc-fix-adrm branch August 20, 2024 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hokolomopo @robodoo @rrahir