[FW][FIX] *: standardization of color representation #2300
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rrahir @LucasLefevre cherrypicking of pull request #2163 failed. stderr: Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?). In the former case, you may want to edit this PR message as well. |
14 tasks
The Alias introduced to prevent Intellisense to resolve simple aliases was broken. As a reminder, it allows us for example to type specific string as `UID` and prevent the variables to be noted as `string`later on in the code.
We handle colors as 'css-valid' representations, as such, several repesentations are equivalent but cannot be compared by strict equality, they need to be converted to the same representation. This commit aims to unify to the uppercase hex representation as it follows the representation yielded by the helper `toHex` which (at this point in time) seems to be the 'rallying' point when manipulating colors. Task: 3193882
rrahir
force-pushed
the
saas-16.1-16.0-fix-color-picker-choice-rar-K_Aj-fw
branch
from
6a8a7e6 to
f823963
Compare
|
@robodoo r+ |
The color picker would not close when the user would click outside of it for the design panels of gauge and scorecard charts. The duplication of design panles is probably to blame here.
rrahir
force-pushed
the
saas-16.1-16.0-fix-color-picker-choice-rar-K_Aj-fw
branch
from
f823963 to
4805e7a
Compare
|
@robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Apr 4, 2023
The Alias introduced to prevent Intellisense to resolve simple aliases was broken. As a reminder, it allows us for example to type specific string as `UID` and prevent the variables to be noted as `string`later on in the code. Part-of: #2300
robodoo
pushed a commit
that referenced
this pull request
Apr 4, 2023
We handle colors as 'css-valid' representations, as such, several repesentations are equivalent but cannot be compared by strict equality, they need to be converted to the same representation. This commit aims to unify to the uppercase hex representation as it follows the representation yielded by the helper `toHex` which (at this point in time) seems to be the 'rallying' point when manipulating colors. Task: 3193882 Part-of: #2300
robodoo
pushed a commit
that referenced
this pull request
Apr 4, 2023
robodoo
pushed a commit
that referenced
this pull request
Apr 4, 2023
The color picker would not close when the user would click outside of it for the design panels of gauge and scorecard charts. The duplication of design panles is probably to blame here. Part-of: #2300
robodoo
pushed a commit
that referenced
this pull request
Apr 4, 2023
closes #2300 Signed-off-by: Lucas Lefèvre (lul) <[email protected]> Signed-off-by: Rémi Rahir (rar) <[email protected]>
14 tasks
Topdev97
added a commit
to Topdev97/o-spreadsheet
that referenced
this pull request
Nov 18, 2024
The Alias introduced to prevent Intellisense to resolve simple aliases was broken. As a reminder, it allows us for example to type specific string as `UID` and prevent the variables to be noted as `string`later on in the code. Part-of: odoo/o-spreadsheet#2300
Topdev97
added a commit
to Topdev97/o-spreadsheet
that referenced
this pull request
Nov 18, 2024
We handle colors as 'css-valid' representations, as such, several repesentations are equivalent but cannot be compared by strict equality, they need to be converted to the same representation. This commit aims to unify to the uppercase hex representation as it follows the representation yielded by the helper `toHex` which (at this point in time) seems to be the 'rallying' point when manipulating colors. Task: 3193882 Part-of: odoo/o-spreadsheet#2300
Topdev97
added a commit
to Topdev97/o-spreadsheet
that referenced
this pull request
Nov 18, 2024
Topdev97
added a commit
to Topdev97/o-spreadsheet
that referenced
this pull request
Nov 18, 2024
The color picker would not close when the user would click outside of it for the design panels of gauge and scorecard charts. The duplication of design panles is probably to blame here. Part-of: odoo/o-spreadsheet#2300
Topdev97
added a commit
to Topdev97/o-spreadsheet
that referenced
this pull request
Nov 18, 2024
closes odoo/o-spreadsheet#2300 Signed-off-by: Lucas Lefèvre (lul) <[email protected]> Signed-off-by: Rémi Rahir (rar) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
We handle colors as 'css-valid' representations, as such, several
repesentations are equivalent but cannot be compared by strict equality,
they need to be converted to the same representation. This commit
aims to unify to the uppercase hex representation as it follows the
representation yielded by the helper
toHexwhich (at this point intime) seems to be the 'rallying' point when manipulating colors.
Task: 3193882
Odoo task ID : TASK_ID
review checklist
Forward-Port-Of: #2163