[FIX] *: standardization of color representation #2163
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hokolomopo
reviewed
Mar 7, 2023
| @@ -13,7 +13,7 @@ import { Range } from "./range"; | |||
| * Intellisense from resolving it. | |||
| * See https://github.com/microsoft/TypeScript/issues/31940#issuecomment-841712377 | |||
| */ | |||
| export type Alias = {}; | |||
| export type Alias = {} & {}; | |||
There was a problem hiding this comment.
The typing on mouse hover seemse to be workign now in VS code on my pc 😊
While we're there we could take the occasion to correclty type the colors that we missed previously. For example the colors in the cell Style, or all the color constants.
There was a problem hiding this comment.
added a commit for this. I might have overlooked some occurences though
rrahir
force-pushed
the
16.0-fix-color-picker-choice-rar
branch
4 times, most recently
from
260f29e to
a3b0cf8
Compare
LucasLefevre
approved these changes
Mar 9, 2023
src/helpers/color.ts
Outdated
| @@ -34,7 +37,10 @@ export function getNextColor() { | |||
|
|
|||
| /** | |||
| * Converts any CSS color value to a standardized hex6 value. | |||
| * Accepts: hex3, hex6, hex8 and rgb (rgba is not supported) | |||
| * Accepts: hex3, hex6, hex8, rgb° and rgba°. | |||
There was a problem hiding this comment.
Ah oui...
needs to be rebased
src/plugins/ui/custom_colors.ts
Outdated
| @@ -104,7 +104,7 @@ export class CustomColorsPlugin extends UIPlugin { | |||
| // again | |||
| [...new Set([...usedColors, ...this.customColors])] | |||
| .filter(isColorValid) | |||
| .map((c) => toHex(c).toLowerCase()) | |||
| .map((c) => toHex(c)) | |||
There was a problem hiding this comment.
can be simplified to .map(toHex)
| @@ -14,7 +14,7 @@ | |||
| <ColorPicker | |||
| t-if="state.openedColorPicker === 'backgroundColor'" | |||
| onColorPicked="(color) => this.setColor(color, 'backgroundColor')" | |||
| currentColor="props.definition.brackground" | |||
| currentColor="props.definition.background" | |||
rrahir
force-pushed
the
16.0-fix-color-picker-choice-rar
branch
2 times, most recently
from
a8b19af to
4b1ad7a
Compare
The Alias introduced to prevent Intellisense to resolve simple aliases was broken. As a reminder, it allows us for example to type specific string as `UID` and prevent the variables to be noted as `string`later on in the code.
We handle colors as 'css-valid' representations, as such, several repesentations are equivalent but cannot be compared by strict equality, they need to be converted to the same representation. This commit aims to unify to the uppercase hex representation as it follows the representation yielded by the helper `toHex` which (at this point in time) seems to be the 'rallying' point when manipulating colors. Task: 3193882
The color picker would not close when the user would click outside of it for the design panels of gauge and scorecard charts. The duplication of design panles is probably to blame here.
rrahir
force-pushed
the
16.0-fix-color-picker-choice-rar
branch
from
4b1ad7a to
ccdaaaa
Compare
|
@LucasLefevre I rebased the branch and changes the docstring with the ° char to something more clear (I hope^^) |
|
robodoo rebase-ff |
|
Merge method set to rebase and fast-forward. |
robodoo
pushed a commit
that referenced
this pull request
Mar 31, 2023
The Alias introduced to prevent Intellisense to resolve simple aliases was broken. As a reminder, it allows us for example to type specific string as `UID` and prevent the variables to be noted as `string`later on in the code. Part-of: #2163
robodoo
pushed a commit
that referenced
this pull request
Mar 31, 2023
We handle colors as 'css-valid' representations, as such, several repesentations are equivalent but cannot be compared by strict equality, they need to be converted to the same representation. This commit aims to unify to the uppercase hex representation as it follows the representation yielded by the helper `toHex` which (at this point in time) seems to be the 'rallying' point when manipulating colors. Task: 3193882 Part-of: #2163
robodoo
pushed a commit
that referenced
this pull request
Mar 31, 2023
robodoo
pushed a commit
that referenced
this pull request
Mar 31, 2023
The color picker would not close when the user would click outside of it for the design panels of gauge and scorecard charts. The duplication of design panles is probably to blame here. Part-of: #2163
robodoo
pushed a commit
that referenced
this pull request
Mar 31, 2023
closes #2163 Signed-off-by: Lucas Lefèvre (lul) <[email protected]>
14 tasks
|
@rrahir @LucasLefevre this pull request has forward-port PRs awaiting action (not merged or closed): |
This was referenced Apr 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
We handle colors as 'css-valid' representations, as such, several
repesentations are equivalent but cannot be compared by strict equality,
they need to be converted to the same representation. This commit
aims to unify to the uppercase hex representation as it follows the
representation yielded by the helper
toHexwhich (at this point intime) seems to be the 'rallying' point when manipulating colors.
Task: 3193882
Odoo task ID : TASK_ID
review checklist