Refactor and improve Windows builds #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MisterDA
force-pushed
the
windows-fixes
branch
11 times, most recently
from
90f283c
to
f507f55
Compare
|
This requires ocaml/opam#5514. |
| "unzip"; | ||
| "git"; | ||
| "m4"; | ||
| "perl"; |
There was a problem hiding this comment.
Why does this require Perl? Dropping vim seems reasonable for CI images though it might surprise some users of the Windows images.
There was a problem hiding this comment.
Usually the perl dependency comes from git. Perl is listed in the installation instructions of OCaml for Windows. We'll drop it once we remove OCaml for Windows.
I'm inclined to remove vim and nano altogether from the CI images, but as it may break workflows we don't know about I won't do it. I thought that starting from scratch, the Windows images didn't need them.
from avsm/ocaml-dockerfile to ocurrent/ocaml-dockerfile.
Light internal refactoring.
Otherwise I always forget why vc-redist is needed.
mingw images also don't need msvs-tools.
I've found out that opam won't bootstrap OCaml without this under MSVC.
It's specific to mingw.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
opam was being build with mingw even in the msvc images. Separate mingw and msvc builds into two functions. Separate the msvc build into more build steps. Fix the origin of Install.cmd from avsm/ocaml-dockerfile to ocurrent/ocaml-dockerfile.
See diff at ocurrent/docker-base-images#223.