Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest msvs-detect #5514

Merged
merged 2 commits into from
Apr 24, 2023
Merged

Conversation

MisterDA
Copy link
Contributor

@MisterDA MisterDA commented Apr 18, 2023

Update to the latest commit (1 commit past 0.5.0). This will help bootstrapping opam with latest Visual Studio.
Update to f988164028edd9db3944b7fc18fc2535e8c70ae4.

  • Add metadata for Visual Studio 2022
  • Use MSYS2_ARG_CONV_EXCL to disable MSYS2 argument mangling,
    replacing the workaround in 0.4.0 (Jonah Beckford)
  • Fix strong/weak detection of the environment compiler (Jonah Beckford)
  • Fix the vswhere invocation to detect Build Tools (Jonah Beckford)

@MisterDA MisterDA force-pushed the update-msvs-detect branch 2 times, most recently from a6470e3 to 1d16658 Compare April 18, 2023 10:57
@MisterDA MisterDA changed the title Update msvs-detect to f988164 Update to latest msvs-detect Apr 18, 2023
Update to [f988164028edd9db3944b7fc18fc2535e8c70ae4][msvs-detect].

- Add metadata for Visual Studio 2022
- Use MSYS2_ARG_CONV_EXCL to disable MSYS2 argument mangling,
  replacing the workaround in 0.4.0 (Jonah Beckford)
- Fix strong/weak detection of the environment compiler (Jonah Beckford)
- Fix the vswhere invocation to detect Build Tools (Jonah Beckford)

[msvs-detect]: metastack/msvs-tools@f988164
@MisterDA
Copy link
Contributor Author

For some unknown reason force-pushing the branch won't trigger the whole set of tests. I've used this patch to bootstrap opam and ocaml using MSVC with its latest version (vs2022, VC redist 17) and got a working opam switch with ocaml 4.14.1, build with msvc. I've successfully build a couple of packages with C stubs.

@rjbou rjbou added this to the 2.2.0~alpha milestone Apr 24, 2023
@rjbou rjbou merged commit e66648f into ocaml:master Apr 24, 2023
@MisterDA MisterDA deleted the update-msvs-detect branch April 25, 2023 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants