Removes the onUnhandledRequest middleware option

[baoshan]

expected to be merged into beta branch

What?

This PR removes the onUnhandledRequest middleware option.

Why?

To respect a proposed general rule that all Octokit middlewares (oauth-app.js, webhooks.js, app.js):

• do NOT handle requests outside pathPrefix (or path) option but provide a natural way for concrete runtimes/frameworks to handle unhandled requests
• always handle requests within pathPrefix (or path) option (returns 404 for unknown routes)

But my code relies on the onUnhandledRequest option!

Because webhook.js only exposes a (shared) middleware for Node.js and Express.js middleware currently, the natural way (to handle unhandled requests) is (AFAICT):

• For native Node.js (http.createServer), check returned boolean value:

const middleware = createNodeMiddleware(webhooks, {});
createServer(async (req, res) => {
  if (await middleware(req, res)) return;
  res.writeHead(404);
  res.end();
}).listen();

• For Express.js, rely on proper handler(s) registered at your desired path(s).

---

View rendered README.md

[wolfy1339]

Test failures are unrelated to this PR.

They should have been caught in #732

[gr2m]

Because webhook.js only exposes a (shared) middleware for Node.js and Express.js middleware currently, the natural way (to handle unhandled requests) is (AFAICT):

* For native Node.js (`http.createServer`), check returned boolean value:

const middleware = createNodeMiddleware(webhooks, {});
createServer(async (req, res) => {
  if (await middleware(req, res)) return;
  res.writeHead(404);
  res.end();
}).listen();

Should we add that to the README?

[baoshan]

Thanks! I’ve fixed that.

[github-actions]

🎉 This PR is included in version 11.0.0-beta.1 🎉

The release is available on:

• GitHub release
• npm package (@beta dist-tag)

Your semantic-release bot 📦🚀

[github-actions]

🎉 This PR is included in version 10.2.0 🎉

The release is available on:

• GitHub release
• npm package (@latest dist-tag)

Your semantic-release bot 📦🚀