Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(middleware): oauth-app has no onUnhandledRequest option #337

Merged
merged 1 commit into from
Sep 15, 2022
Merged

fix(middleware): oauth-app has no onUnhandledRequest option #337

merged 1 commit into from
Sep 15, 2022

Conversation

baoshan
Copy link
Contributor

@baoshan baoshan commented Sep 9, 2022

This PR keeps app.js updated if we could remove the onUnhandledRequest option from oauth-app.js.

Related PR: #341

@baoshan baoshan mentioned this pull request Sep 9, 2022
Merged
@gr2m gr2m changed the base branch from master to beta September 9, 2022 17:42
@oscard0m oscard0m added the bug label Sep 10, 2022
@oscard0m oscard0m added Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR and removed bug labels Sep 10, 2022
oscard0m
oscard0m reviewed Sep 10, 2022
View reviewed changes
package.json Outdated Show resolved Hide resolved
@gr2m
Copy link
Contributor

gr2m commented Sep 10, 2022

@baoshan is this PR ready for review / beta release?

@baoshan baoshan marked this pull request as ready for review September 11, 2022 01:02
@baoshan baoshan marked this pull request as draft September 11, 2022 01:06
@baoshan
Copy link
Contributor Author

baoshan commented Sep 11, 2022

Thanks. Please review it.

I’ll open another PR once webhooks has onUnhandledRequest option removed.

@baoshan baoshan marked this pull request as ready for review September 11, 2022 02:07
@baoshan
Copy link
Contributor Author

baoshan commented Sep 11, 2022

This is the PR to webhooks.js.

@wolfy1339
Copy link
Member

This needs a final rebase

@baoshan baoshan force-pushed the upgrade_oauth-app branch 2 times, most recently from f0a1d63 to a8538e5 Compare September 12, 2022 03:40
@baoshan
Copy link
Contributor Author

baoshan commented Sep 12, 2022 •
edited
Loading

Rebased. Depends on "@octokit/webhooks": "11.0.0-beta.1". README updated.

@baoshan baoshan force-pushed the upgrade_oauth-app branch 2 times, most recently from 98d18a1 to 311f618 Compare September 12, 2022 03:48
gr2m
gr2m reviewed Sep 12, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
@baoshan
refactor(middleware)!: remove onUnhandledRequest middleware option
f55d03a 
BREAKING CHANGE: onUnhandledRequest middleware option is removed
gr2m
gr2m approved these changes Sep 15, 2022
View reviewed changes
Copy link
Contributor

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't have the time to thoroughly review it and I won't be able to soon. But I don't want you to get blocked and really appreciate all your work you put into this, so I'm going to merge it into beta.

@gr2m gr2m merged commit e88581e into octokit:beta Sep 15, 2022
@github-actions
Copy link

🎉 This PR is included in version 14.0.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oscard0m oscard0m oscard0m left review comments

@wolfy1339 wolfy1339 wolfy1339 approved these changes

@gr2m gr2m gr2m approved these changes

Assignees
No one assigned
Labels
Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@baoshan @gr2m @wolfy1339 @oscard0m