Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump octokit/types #700

Merged
merged 3 commits into from
Dec 18, 2023
Merged

bump octokit/types #700

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0c21463
WIP octokit/openapi updated
octokitbot Dec 4, 2023
89c4c25
Use .js in import for RestEndpointMethodTypes
kfcampbell Dec 18, 2023
b51f714
npm run update-endpoints:types
kfcampbell Dec 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
"author": "Gregor Martynus (https://twitter.com/gr2m)",
"license": "MIT",
"dependencies": {
"@octokit/types": "^12.3.0"
"@octokit/types": "^12.4.0"
},
"devDependencies": {
"@octokit/core": "^5.0.0",
Expand Down
2 changes: 1 addition & 1 deletion scripts/update-endpoints/types.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ async function generateTypes() {
const methodTypesSource = await format(
[
`import type { EndpointInterface, RequestInterface } from "@octokit/types";`,
`import type { RestEndpointMethodTypes } from "./parameters-and-response-types";`,
`import type { RestEndpointMethodTypes } from "./parameters-and-response-types.js";`,
"",
`export type RestEndpointMethods = {
${RestEndpointMethodNamespaceTypes.join("\n")}
Expand Down
2 changes: 1 addition & 1 deletion src/generated/method-types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import type { EndpointInterface, RequestInterface } from "@octokit/types";
import type { RestEndpointMethodTypes } from "./parameters-and-response-types.js";
import type { RestEndpointMethodTypes } from "./parameters-and-response-types";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wolfy1339 It's not ideal that this is auto-removed. Perhaps we should rework our automation a little bit so those changes are ignored.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that would need to be changed here:

plugin-rest-endpoint-methods.js/scripts/update-endpoints/types.mjs

Line 90 in 56bab3e

`import type { RestEndpointMethodTypes } from "./parameters-and-response-types";`,

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I've added that change on to this PR.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woops, didn't catch that one. Thanks for fixing it

wolfy1339 marked this conversation as resolved.
Show resolved Hide resolved

export type RestEndpointMethods = {
actions: {
Expand Down