bump octokit/types #700
Merged
bump octokit/types #700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
octokitbot
added
the
Type: Maintenance
kfcampbell
reviewed
Dec 4, 2023
src/generated/method-types.ts
Outdated
| @@ -1,5 +1,5 @@ | |||
| import type { EndpointInterface, RequestInterface } from "@octokit/types"; | |||
| import type { RestEndpointMethodTypes } from "./parameters-and-response-types.js"; | |||
| import type { RestEndpointMethodTypes } from "./parameters-and-response-types"; | |||
There was a problem hiding this comment.
@wolfy1339 It's not ideal that this is auto-removed. Perhaps we should rework our automation a little bit so those changes are ignored.
There was a problem hiding this comment.
that would need to be changed here:
There was a problem hiding this comment.
Thank you! I've added that change on to this PR.
There was a problem hiding this comment.
Woops, didn't catch that one. Thanks for fixing it
wolfy1339
reviewed
Dec 18, 2023
kfcampbell
changed the title
kfcampbell
approved these changes
Dec 18, 2023
|
🎉 This PR is included in version 10.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there are any new endpoints, then the code changes will likely required an update of
@octokit/types. It should have received a pull request as well, merge & release it first. The@octokit/typesshould be updated automatically shortly after in this pull request.Make sure to update the commits so that the merge results in helpful release notes, see Merging the Pull Request & releasing a new version.
In general
docsprefixfix(typescript)prefixfixif a problem was resolved,featif new endpoints / parameters were added, andfeat(deprecation)if a method was deprecated.