Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support additional ways to specify observables. #77

Merged
merged 10 commits into from
Apr 3, 2024

Conversation

rmouritzen-splunk
Copy link
Contributor

@rmouritzen-splunk rmouritzen-splunk commented Mar 4, 2024

Before this change:

  • By type in dictionary using observable property in types
  • By object (which can also be thought of as types) using top-level observable property

Add:

  • By attribute in dictionary using observable property in attributes
  • By attribute in object using observable property in attributes
  • By attribute in class using observable property in attributes
  • By attribute path in class using top level observables property

Other:

  • Fix profile checkbox on Firefox.
  • Improve object attribute name tooltip to work like event class attribute name tooltip, showing attribute source as caption of object along with inheritance hierarchy path back to current object (issue: The "source" of object attributes are not accurate #71).
  • Add dictionary attributes to the GET /export/schema API. This is needed for automatic observable generation so dictionary attributes observable definitions are considered before class and object specific attributes.

NOTE: Changes are also necessary in ocsf-schema/metaschema and ocsf-validator.

Related issues:

Related PRs:

Before this change:
- By type
- By object (which can also be thought of as types)

Add:
- By attribute in dictionary
- By attribute path in class definitions.

Also fix profile checkbox on Firefox.

With this commit, add by attribute in dictionary. By class attribute path is next.
@rmouritzen-splunk rmouritzen-splunk marked this pull request as draft March 4, 2024 20:20
@rmouritzen-splunk rmouritzen-splunk marked this pull request as ready for review March 9, 2024 06:06
@rmouritzen-splunk rmouritzen-splunk changed the title DRAFT: Support additional ways to specify observables. Support additional ways to specify observables. Mar 9, 2024
@rmouritzen-splunk rmouritzen-splunk marked this pull request as draft March 21, 2024 22:56
@rmouritzen-splunk rmouritzen-splunk marked this pull request as ready for review March 22, 2024 00:18
@rmouritzen-splunk rmouritzen-splunk marked this pull request as draft March 28, 2024 14:23
@rmouritzen-splunk rmouritzen-splunk changed the title Support additional ways to specify observables. DRAFT: Support additional ways to specify observables. Mar 28, 2024
@rmouritzen-splunk rmouritzen-splunk added the enhancement New feature or request label Mar 28, 2024
@rmouritzen-splunk rmouritzen-splunk changed the title DRAFT: Support additional ways to specify observables. Support additional ways to specify observables. Mar 29, 2024
@rmouritzen-splunk rmouritzen-splunk marked this pull request as ready for review March 29, 2024 00:34
Copy link

@query-jeremy query-jeremy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense. I especially like the additions in test/test_ocsf_schema.

Copy link

@zschmerber zschmerber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for making this!

@rmouritzen-splunk rmouritzen-splunk merged commit 64ccde2 into ocsf:main Apr 3, 2024
1 check passed
@rmouritzen-splunk rmouritzen-splunk deleted the observables branch April 3, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants