-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support additional ways to specify observables. #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change: - By type - By object (which can also be thought of as types) Add: - By attribute in dictionary - By attribute path in class definitions. Also fix profile checkbox on Firefox. With this commit, add by attribute in dictionary. By class attribute path is next.
rmouritzen-splunk
changed the title
DRAFT: Support additional ways to specify observables.
Support additional ways to specify observables.
Mar 9, 2024
rmouritzen-splunk
requested review from
floydtree,
alancommike,
mikeradka and
query-jeremy
and removed request for
alancommike
March 10, 2024 20:28
This was referenced Mar 11, 2024
…s" and patch_type
rmouritzen-splunk
changed the title
Support additional ways to specify observables.
DRAFT: Support additional ways to specify observables.
Mar 28, 2024
…ed for automatic observable generation.
rmouritzen-splunk
changed the title
DRAFT: Support additional ways to specify observables.
Support additional ways to specify observables.
Mar 29, 2024
query-jeremy
approved these changes
Apr 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes sense. I especially like the additions in test/test_ocsf_schema
.
zschmerber
approved these changes
Apr 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks for making this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change:
observable
property in typesobservable
propertyAdd:
observable
property in attributesobservable
property in attributesobservable
property in attributesobservables
propertyOther:
GET /export/schema
API. This is needed for automatic observable generation so dictionary attributes observable definitions are considered before class and object specific attributes.NOTE: Changes are also necessary in
ocsf-schema/metaschema
andocsf-validator
.Related issues:
observables
data types, add Name & ID pairs ocsf-schema#960Related PRs: