Validate observables, including new ways to define #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 11, 2024
query-jeremy
approved these changes
Mar 12, 2024
There was a problem hiding this comment.
This looks good and fits right in with the rest of the validator.
I pushed a change to fix an invalid f-string, but that let me run the validator against a recent clone of ocsf-schema.
I'd like to see unit tests to verify that IllegalObservableTypeIDError and ObservableTypeIDCollisionError are raised when expected, but those can be added in a follow up PR to unblock work on the OCSF Server. Otherwise it looks good.
Nice work!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs: