Refactoring Discovery EOC event classes (issue 958) #967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxhotta
requested review from
floydtree,
Aniak5,
mikeradka and
zschmerber
as code owners
maxhotta
added
discovery
|
There is one other item I'd like to propose: this was raised by @mikeradka previously, but I'd like to remove the MacOS extension and expand the Startup Application Query to be for all OS types. |
|
Looks really good Max. Could you also add a CHANGELOG.md update as well? |
|
@pagbabian-splunk I've added the CHANGELOG entries for the event classes added. I've left out the Macos profile in the CHANGELOG, as I'm planning to propose another PR to refactor/remove it in favor of expanding the Startup Application Query class to apply to all OS types. |
pagbabian-splunk
previously approved these changes
Feb 24, 2024
…ent change. Also fixed typo.
# Conflicts: # events/discovery/network_connection_query.json
pagbabian-splunk
approved these changes
Mar 6, 2024
floydtree
approved these changes
Mar 6, 2024
rmouritzen-splunk
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue:
Address: #958
Description of Changes:
Refactoring of Discovery / EOC event classes for consistency with other event types in the category.
Refactored all _info classes added as part of the original PR to use a _query suffix.
Using the query_info object to capture search criteria and details
Activity id has been updated to include query
Added query_result_id to hold the results of the query, as well as its sibling attribute