Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestions for update to the 1.2 _info family of Discovery classes #958

Open
pagbabian-splunk opened this issue Feb 7, 2024 · 0 comments
Assignees
Labels
discovery Issues related to Discovery Category enhancement New feature or request

Comments

@pagbabian-splunk
Copy link
Contributor

There is still confusion between the original Discovery classes that have the _info suffix and the new family of classes with that suffix. The former classes (Device Inventory Info, User Inventory Info) are clearly inventory requests, populating the Device and User respectively. However User Info is a targeted query of specific users. The other new _info classes are all similar and currently aren't confusing (e.g. File Info Folder Info etc.). However they have different semantics than the Inventory Info classes (i.e. Log Collect).

  1. I suggest renaming this family of classes using the Query term rather than the Info term (i.e. `_query).
  2. Add the query_info attribute as Optional to include details on the query if possible (although it may be self-evident with the class name specificity).
  3. Change the activity_id to be Query rather than the current values which are results of the query (e.g. Exists).
  4. Add a new query_result_id enum and sibling for what are now listed in activity_id (Exists Partial Does not exist Error Unsupported).
@mikeradka mikeradka added enhancement New feature or request discovery Issues related to Discovery Category labels May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discovery Issues related to Discovery Category enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants