-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Load Balancer Profile for the Network Activity classes #897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanbvail
added
enhancement
New feature or request
network_activity
Issues related to Network Activity Category
labels
Dec 19, 2023
nathanbvail
requested review from
Aniak5,
pagbabian-splunk,
floydtree and
mikeradka
December 19, 2023 21:11
Signed-off-by: Nathan <[email protected]>
Aniak5
reviewed
Dec 20, 2023
Aniak5
reviewed
Dec 20, 2023
mikeradka
approved these changes
Dec 20, 2023
I don't see the plural of |
nathanbvail
commented
Dec 21, 2023
nathanbvail
commented
Dec 21, 2023
Aniak5
approved these changes
Dec 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great @nathanbvail, nice work!
pagbabian-splunk
approved these changes
Dec 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: 896
Description of changes:
Changes are a result of the conversations in previous PR 885.
Changes are:
Load Balancer
profile that can be applied across theNetwork Activity
classes. The profile contains a singularload_balancer
attribute.load_balancer
object.endpoint_connection
object.load_balancer
,endpoint_connection
, and creation ofnetwork_endpoint
Attached screenshots: