Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Load Balancer object for HTTP Activity 4002 #885

Closed
wants to merge 2 commits into from

Conversation

nathanbvail
Copy link
Contributor

Related Issue: Discussion 846

Description of changes: Updated from Draft PR 861.

  • Created a new Load Balancer object that contains specific Load Balancer related information and added that object as an optional attribute in HTTP Activity 4002
  • Created a new endpoint_connections object that sits as an attribute inside of the load_balancer object
  • Created a new endpoint attribute that is an array of Network Endpoint objects
  • Lastly, updated the dictionary with the necessary additions endpoint, endpoint_connections, and load_balancer

@nathanbvail nathanbvail added the network_activity Issues related to Network Activity Category label Dec 7, 2023
@nathanbvail nathanbvail self-assigned this Dec 7, 2023
@nathanbvail nathanbvail marked this pull request as ready for review December 7, 2023 22:00
"attributes": {
"code": {
"caption": "Response Code",
"description": "A numeric response status code detailing the connection.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may want to reword this to be A numerical response status code providing details about the connection..

},
"endpoint": {
"caption": "Endpoint Array",
"description": "An array of endpoint/s that fielded the connection attempt.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is no longer an array. And instead of endpoint we should be using network_endpoint.

{
"caption": "Endpoint Connections",
"name": "endpoint_connections",
"description": "The Endpoint Connections object contains information regarding the connections to multiple destination endpoints.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be singular as its no longer an array but a single instance of an endpoint and response code.

"caption": "Endpoint Connections",
"description": "Connection attempts and their responses. See specific usage.",
"is_array": true,
"type": "endpoint_connections"
Copy link
Contributor

@Aniak5 Aniak5 Dec 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The type should become singular per the comments on that specific object.

@@ -1343,6 +1343,18 @@
"description": "The end time of a time period. See specific usage.",
"type": "timestamp_t"
},
"endpoint": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is no longer needed and can be deleted.

@nathanbvail
Copy link
Contributor Author

nathanbvail commented Dec 13, 2023

Comments from 12/13 meeting:

  • Create a LB profile that contains the LB object, this will allow for additional Load Balancer types to utilize the objects across Networking classes (i.e. HTTP Activity & Network Activity classes)
  • Remove endpoint from the dictionary & replace endpoint attribute with the existing network_endpoint attribute inside of endpoint_connections.json

@nathanbvail
Copy link
Contributor Author

nathanbvail commented Dec 13, 2023

@Aniak5 / @pagbabian-splunk - Before I commit changes , are we all in agreement on going forward with a Load Balancer Profile that can be applied to the Networking class (expanding to other classes if needed) ?

If that is the case then I will remove the load_balancer attribute from http.json and transform this PR to just be the object.

@Aniak5
Copy link
Contributor

Aniak5 commented Dec 14, 2023

@Aniak5 / @pagbabian-splunk - Before I commit changes , are we all in agreement on going forward with a Load Balancer Profile that can be applied to the Networking class (expanding to other classes if needed) ?

If that is the case then I will remove the load_balancer attribute from http.json and transform this PR to just be the object.

Yup, that's exactly what we want to do @nathanbvail.

@nathanbvail
Copy link
Contributor Author

Uploading screenshots of the LB Profile changes - image
image

@nathanbvail
Copy link
Contributor Author

nathanbvail commented Dec 19, 2023

Per todays OCSF General Call (12/19) - I will be closing out this PR & creating a new PR due to the profile approach instead of an object which resulted in fairly significant changes from the initial draft.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
network_activity Issues related to Network Activity Category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants