-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Load Balancer object for HTTP Activity 4002 #885
Conversation
"attributes": { | ||
"code": { | ||
"caption": "Response Code", | ||
"description": "A numeric response status code detailing the connection.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may want to reword this to be A numerical response status code providing details about the connection.
.
}, | ||
"endpoint": { | ||
"caption": "Endpoint Array", | ||
"description": "An array of endpoint/s that fielded the connection attempt.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is no longer an array. And instead of endpoint we should be using network_endpoint
.
{ | ||
"caption": "Endpoint Connections", | ||
"name": "endpoint_connections", | ||
"description": "The Endpoint Connections object contains information regarding the connections to multiple destination endpoints.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be singular as its no longer an array but a single instance of an endpoint and response code.
"caption": "Endpoint Connections", | ||
"description": "Connection attempts and their responses. See specific usage.", | ||
"is_array": true, | ||
"type": "endpoint_connections" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The type
should become singular per the comments on that specific object.
@@ -1343,6 +1343,18 @@ | |||
"description": "The end time of a time period. See specific usage.", | |||
"type": "timestamp_t" | |||
}, | |||
"endpoint": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is no longer needed and can be deleted.
Comments from 12/13 meeting:
|
@Aniak5 / @pagbabian-splunk - Before I commit changes , are we all in agreement on going forward with a If that is the case then I will remove the |
Yup, that's exactly what we want to do @nathanbvail. |
Per todays OCSF General Call (12/19) - I will be closing out this PR & creating a new PR due to the profile approach instead of an object which resulted in fairly significant changes from the initial draft. |
Related Issue: Discussion 846
Description of changes: Updated from Draft PR 861.
Load Balancer
object that contains specific Load Balancer related information and added that object as an optional attribute in HTTP Activity 4002endpoint_connections
object that sits as an attribute inside of theload_balancer
objectendpoint
attribute that is an array of Network Endpoint objectsendpoint
,endpoint_connections
, andload_balancer