Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 689: Add type/type_id to endpoint object #690

Merged
merged 4 commits into from
Jul 13, 2023
Merged

Issue 689: Add type/type_id to endpoint object #690

merged 4 commits into from
Jul 13, 2023

Conversation

Aniak5
Copy link
Contributor

@Aniak5 Aniak5 commented Jul 13, 2023 •
edited
Loading

Related Issue: #689

Description of changes:

  • Moved device type enums to endpoint object
  • Updates device/network_endpoint objects to have specific type requirements/descriptions
image

@Aniak5 Aniak5 added network_activity Issues related to Network Activity Category non_breaking Non Breaking, backwards compatible changes labels Jul 13, 2023
@Aniak5 Aniak5 self-assigned this Jul 13, 2023
mikeradka
mikeradka previously approved these changes Jul 13, 2023
View reviewed changes
Copy link
Contributor

@mikeradka mikeradka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikeradka mikeradka self-requested a review July 13, 2023 16:44
@mikeradka
Copy link
Contributor

Hi @Aniak5 , - Along the topic of Endpoint - saw a minor grammatical error in the description of the Endpoint observable in the observable object

The endpoint object describes an entity that has name, uid, and IP address.
should be
The endpoint object describes an entity that has a name, uid, and IP address.

Is this something you could add to this PR?

rroupski
rroupski requested changes Jul 13, 2023
View reviewed changes
Copy link
Contributor

@rroupski rroupski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The endpoint object is not a private object, so we should rename the file as endpoint.json.

@Aniak5
Copy link
Contributor Author

Aniak5 commented Jul 13, 2023

Hi @Aniak5 , - Along the topic of Endpoint - saw a minor grammatical error in the description of the Endpoint observable in the observable object

The endpoint object describes an entity that has name, uid, and IP address. should be The endpoint object describes an entity that has a name, uid, and IP address.

Is this something you could add to this PR?

Yup definitely, good catch @mr-splunk!

@Aniak5
Rename _endpoint to endpoint
a4b6c1f 
Signed-off-by: Ania Kacewicz <[email protected]>
@floydtree floydtree merged commit f88e8a2 into ocsf:main Jul 13, 2023
@Aniak5 Aniak5 added the v1.1.0 Changes marked for v1.1.0 of OCSF label Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeradka mikeradka mikeradka approved these changes

@floydtree floydtree floydtree approved these changes

@rroupski rroupski rroupski approved these changes

@pagbabian-splunk pagbabian-splunk Awaiting requested review from pagbabian-splunk pagbabian-splunk is a code owner

Assignees

@Aniak5 Aniak5

Labels
network_activity Issues related to Network Activity Category non_breaking Non Breaking, backwards compatible changes v1.1.0 Changes marked for v1.1.0 of OCSF
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Aniak5 @mikeradka @rroupski @floydtree