Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add type_id to the endpoint object #689

Closed
Aniak5 opened this issue Jul 13, 2023 · 0 comments
Closed

Add type_id to the endpoint object #689

Aniak5 opened this issue Jul 13, 2023 · 0 comments
Assignees
@Aniak5
Labels
network_activity Issues related to Network Activity Category non_breaking Non Breaking, backwards compatible changes

Comments

@Aniak5
Copy link
Contributor

Aniak5 commented Jul 13, 2023 •
edited
Loading

Currently, both the network_endpoint and the device object extend the endpoint object. The device object contains type_ids whereas the endpoint and the network_endpoint do not. These types are applicable to all endpoints. Move the type_id enums to the endpoint object so that both the network_endpoint and the device objects can inherit these enums (seen below).

The device type ID.
0	Unknown
The type is unknown.
1	Server
2	Desktop
3	Laptop
4	Tablet
5	Mobile
6	Virtual
7	IOT
8	Browser
99	Other
@Aniak5 Aniak5 added network_activity Issues related to Network Activity Category non_breaking Non Breaking, backwards compatible changes labels Jul 13, 2023
@Aniak5 Aniak5 self-assigned this Jul 13, 2023
@Aniak5 Aniak5 mentioned this issue Jul 13, 2023
Merged
@Aniak5 Aniak5 closed this as completed Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Aniak5 Aniak5

Labels
network_activity Issues related to Network Activity Category non_breaking Non Breaking, backwards compatible changes
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Aniak5