Making powervc-certificate optional #86
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: irapandey The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Welcome @irapandey! It looks like this is your first PR to ocp-power-automation/ocp4-playbooks-extras 🎉 |
ppc64le-cloud-bot
added
the
size/M
Signed-off-by: ira-pandey1 <[email protected]>
irapandey
force-pushed
the
powervc-cert-optional
branch
from
bd85cfb to
41c3eac
Compare
|
/lgtm |
|
/hold |
ppc64le-cloud-bot
added
the
do-not-merge/hold
yussufsh
requested changes
Oct 21, 2024
| msg: "PowerVC certificate secret is not present!" | ||
| when: powervc_certificate.resources | length == 0 | ||
|
|
||
| - fail: | ||
| - name: If powervc-certificate is empty |
There was a problem hiding this comment.
This task will fail if the above condition is true.
There was a problem hiding this comment.
I ran it on a cluster - it just gives a message
TASK [ocp-csi-driver : Check if the PowerVC certificate's secret is exists] *************************************************************************************************************************************************************************
ok: [localhost]
TASK [ocp-csi-driver : If the powervc-certificate does not exists in default namespace] *************************************************************************************************************************************************************
ok: [localhost] => {
"msg": "PowerVC certificate secret is not present!"
}
TASK [ocp-csi-driver : If powervc-certificate is empty] *********************************************************************************************************************************************************************************************
ok: [localhost] => {
"msg": "PowerVC certificate is empty! Please check the certificate's secret."
}
There was a problem hiding this comment.
I have removed the name parameters and replaces fail with debug
There was a problem hiding this comment.
TASK [ocp-csi-driver : Check if the PowerVC certificate's secret is exists] *************************************************************************************************************************************************************************
ok: [localhost]
TASK [ocp-csi-driver : If the powervc-certificate does not exists in default namespace] *************************************************************************************************************************************************************
ok: [localhost] => {
"msg": "PowerVC certificate secret is not present!"
}
TASK [ocp-csi-driver : debug] ***********************************************************************************************************************************************************************************************************************
ok: [localhost] => {
"msg": "PowerVC certificate is empty! Please check the certificate's secret."
}
TASK [ocp-csi-driver : Create namespace for CSI driver validation] **********************************************************************************************************************************************************************************
ok: [localhost]
yussufsh
requested changes
Oct 21, 2024
|
New changes are detected. LGTM label has been removed. |
ppc64le-cloud-bot
added
size/S
irapandey
force-pushed
the
powervc-cert-optional
branch
from
58e8be6 to
e0743c8
Compare
|
@varad-ahirwadkar - can you take a look? |
| msg: "PowerVC certificate secret is not present!" | ||
| when: powervc_certificate.resources | length == 0 | ||
|
|
||
| - fail: | ||
| - debug: | ||
| msg: "PowerVC certificate is empty! Please check the certificate's secret." | ||
| when: > | ||
| (powervc_certificate.resources[0].data.certificate is not defined) or |
There was a problem hiding this comment.
Can we add one more condition to validate only if the certificate is exists powervc_certificate.resources | length != 0 ?
There was a problem hiding this comment.
made the changes - can you review and let me know if that looks good
irapandey
force-pushed
the
powervc-cert-optional
branch
from
e0743c8 to
caf33f2
Compare
Signed-off-by: ira-pandey1 <[email protected]>
irapandey
force-pushed
the
powervc-cert-optional
branch
from
caf33f2 to
2cc1088
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is resolving issue #85
Made changes in documentation as well as powervc-certificate is optional