review changes

Signed-off-by: ira-pandey1 <[email protected]>
ocp-power-automation · Dec 2, 2024 · 2cc1088 · 2cc1088
1 parent 41c3eac
commit 2cc1088
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 21 deletions.
diff --git a/playbooks/roles/ocp-csi-driver/README.md b/playbooks/roles/ocp-csi-driver/README.md
@@ -16,24 +16,24 @@ Requirements
 - Running OCP 4.x cluster is needed.
 - Cluster must not contain default StorageClass.
 - Optional : 
-  - A secret with PowerVC certificate in the `default` namespace 
-    Secret name should be `powervc-certificate` and must contains `certificate` field.
-    eg. 
-
-    ```
-    apiVersion: v1
-    kind: Secret
-    metadata:
-      name: powervc-certificate
-      namespace: default
-    type: Opaque
-    stringData:
-      certificate: |
-        -----BEGIN CERTIFICATE-----
-        IBAgwIBUCCAwIBAgIUn2gAbw0LWHtozBNiLdUtELvr1pyPAzcNAQYjAwDQYJKoZIhv
-        ...
-        Un2gAIBAb -----END CERTIFICATE-----
-    ```
+- A secret with PowerVC certificate in the `default` namespace 
+  Secret name should be `powervc-certificate` and must contains `certificate` field.
+  eg. 
+
+  ```
+  apiVersion: v1
+  kind: Secret
+  metadata:
+    name: powervc-certificate
+    namespace: default
+  type: Opaque
+  stringData:
+    certificate: |
+      -----BEGIN CERTIFICATE-----
+      IBAgwIBUCCAwIBAgIUn2gAbw0LWHtozBNiLdUtELvr1pyPAzcNAQYjAwDQYJKoZIhv
+      ...
+      Un2gAIBAb -----END CERTIFICATE-----
+  ```
 
 Role Variables
 --------------

diff --git a/playbooks/roles/ocp-csi-driver/tasks/main.yml b/playbooks/roles/ocp-csi-driver/tasks/main.yml
@@ -124,12 +124,12 @@
       msg: "PowerVC certificate secret is not present!"
     when: powervc_certificate.resources | length == 0
 
-  - name: If powervc-certificate is empty
-    debug:
+  - debug:
       msg: "PowerVC certificate is empty! Please check the certificate's secret."
     when: >
           (powervc_certificate.resources[0].data.certificate is not defined) or
-          (powervc_certificate.resources[0].data.certificate | length == 0)
+          (powervc_certificate.resources[0].data.certificate | length == 0) or
+          (powervc_certificate.resources | length != 0)
 
   - name: Create namespace for CSI driver validation
     k8s: